From 91feb38f57cf2bfd91537dba00809f9a995d63cb Mon Sep 17 00:00:00 2001 From: az Date: Wed, 27 Jul 2022 09:02:45 +0200 Subject: [PATCH] changes from review --- .../resources/gitea/appini-env-configmap.yaml | 19 ++++++++----------- src/main/resources/gitea/deployment.yaml | 1 - 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/main/resources/gitea/appini-env-configmap.yaml b/src/main/resources/gitea/appini-env-configmap.yaml index 38d5e58..01cddc1 100644 --- a/src/main/resources/gitea/appini-env-configmap.yaml +++ b/src/main/resources/gitea/appini-env-configmap.yaml @@ -7,9 +7,9 @@ data: #[attachments] GITEA__attachments__PATH: /data/gitea/attachments - #[databaser] + #[database] GITEA__database__DB_TYPE: "postgres" - GITEA__database__HOST: "postgresql-service:5432" # Service.Namespace.svc.cluster.local + GITEA__database__HOST: "postgresql-service:5432" GITEA__database__NAME: gitea GITEA__database__LOG_SQL: "false" GITEA__database__SSL_MODE: disable @@ -20,7 +20,7 @@ data: RUN_MODE: prod RUN_USER: git - #federation] + #[federation] GITEA__federation__ENABLED: "true" #[indexer] @@ -63,17 +63,14 @@ data: GITEA__server__SSH_DOMAIN: FQDN GITEA__server__ROOT_URL: URL # TODO: Review jem - 2022/07/26 - what does http port mean? The outgoning port should be 80 for http // 443 for https! - GITEA__server__HTTP_PORT: "3000" - GITEA__server__SSH_PORT: "2222" + GITEA__server__HTTP_PORT: "3000" # HTTP listen port of the server (in the pod) + GITEA__server__SSH_PORT: "2222" # SSH port displayed in clone URL #[service] - # TODO: Review jem - 2022/07/26 - why? Does not match to whitelisting - GITEA__service__DISABLE_REGISTRATION: "true" + GITEA__service__DISABLE_REGISTRATION: "false" GITEA__service__REQUIRE_SIGNIN_VIEW: "false" - # TODO: Review jem - 2022/07/26 - why? Does not match to whitelisting - GITEA__service__REGISTER_EMAIL_CONFIRM: "false" - # TODO: Review jem - 2022/07/26 - why? Does not match to whitelisting - GITEA__service__ENABLE_NOTIFY_MAIL: "false" + GITEA__service__REGISTER_EMAIL_CONFIRM: "true" + GITEA__service__ENABLE_NOTIFY_MAIL: "true" GITEA__service__EMAIL_DOMAIN_WHITELIST: WHITELISTDOMAINS GITEA__service__ALLOW_ONLY_EXTERNAL_REGISTRATION: "false" GITEA__service__ENABLE_CAPTCHA: "false" diff --git a/src/main/resources/gitea/deployment.yaml b/src/main/resources/gitea/deployment.yaml index cc2149b..b1abf8a 100644 --- a/src/main/resources/gitea/deployment.yaml +++ b/src/main/resources/gitea/deployment.yaml @@ -18,7 +18,6 @@ spec: spec: containers: - name: gitea - # TODO: Review jem - 2022/07/26 - latest release? image: gitea/gitea:1.16.9 imagePullPolicy: IfNotPresent # config settings