From 861b43b4bfc89bfe22ca766bea308887dd0f1d7a Mon Sep 17 00:00:00 2001 From: patdyn Date: Tue, 27 Aug 2024 16:26:42 +0200 Subject: [PATCH] Add more todos --- src/main/cljc/dda/c4k_keycloak/keycloak.cljc | 2 +- src/main/resources/keycloak/configmap.yaml | 4 ++++ src/main/resources/keycloak/deployment.yaml | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/main/cljc/dda/c4k_keycloak/keycloak.cljc b/src/main/cljc/dda/c4k_keycloak/keycloak.cljc index 6f68bdd..3ba2b75 100644 --- a/src/main/cljc/dda/c4k_keycloak/keycloak.cljc +++ b/src/main/cljc/dda/c4k_keycloak/keycloak.cljc @@ -25,7 +25,7 @@ #?(:cljs (defmethod yaml/load-resource :keycloak [resource-name] (get (inline-resources "keycloak") resource-name))) - +; TODO: Use rate-limit ingress (defn-spec generate-ingress cp/map-or-seq? [config config?] (ing/generate-ingress-and-cert diff --git a/src/main/resources/keycloak/configmap.yaml b/src/main/resources/keycloak/configmap.yaml index 659dbf7..d7fd10f 100644 --- a/src/main/resources/keycloak/configmap.yaml +++ b/src/main/resources/keycloak/configmap.yaml @@ -13,3 +13,7 @@ data: DB_ADDR: postgresql-service DB_SCHEMA: public DB_DATABASE: postgres + # TODO Do we need to enable http, as we are behind ingress? + # KC_HTTP_ENABLED: true + # TODO Maybe also enable load shedding + # KC_HTTP_MAX_QUEUED_REQUESTS: 2000 diff --git a/src/main/resources/keycloak/deployment.yaml b/src/main/resources/keycloak/deployment.yaml index 20d2d52..124d7b1 100644 --- a/src/main/resources/keycloak/deployment.yaml +++ b/src/main/resources/keycloak/deployment.yaml @@ -15,6 +15,7 @@ spec: labels: app: keycloak spec: + # TODO: Add Resource allocations containers: - name: keycloak image: quay.io/keycloak/keycloak:20.0.3