From 16189ee9c46814ffe7fd84f2e4996cbeced2a3df Mon Sep 17 00:00:00 2001 From: erik Date: Tue, 1 Nov 2022 14:06:56 +0100 Subject: [PATCH] [Skip-Ci] Remove ToDo markers --- src/main/cljc/dda/c4k_website/ingress_cert.cljc | 1 - src/main/cljc/dda/c4k_website/website.cljc | 1 - src/main/resources/ingress/http-ingress.yaml | 2 +- src/test/cljc/dda/c4k_website/core_test.cljc | 2 -- 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/main/cljc/dda/c4k_website/ingress_cert.cljc b/src/main/cljc/dda/c4k_website/ingress_cert.cljc index 1ba1f3a..91ec953 100644 --- a/src/main/cljc/dda/c4k_website/ingress_cert.cljc +++ b/src/main/cljc/dda/c4k_website/ingress_cert.cljc @@ -18,7 +18,6 @@ (s/def ::service-port pos-int?) (s/def ::fqdns (s/coll-of pred/fqdn-string?)) -; TODO: Review jem 2022/10/26: Namespace is called ingress but we do more: Ingress & cert -> rename ore mv. certificate to own ns (def ingress? (s/keys :req-un [::fqdns ::ingress-name ::service-name ::service-port] :opt-un [::issuer ::cert-name])) diff --git a/src/main/cljc/dda/c4k_website/website.cljc b/src/main/cljc/dda/c4k_website/website.cljc index 7926653..778cd00 100644 --- a/src/main/cljc/dda/c4k_website/website.cljc +++ b/src/main/cljc/dda/c4k_website/website.cljc @@ -71,7 +71,6 @@ branch string?] (str "https://" host "/api/v1/repos/" user "/" repo "/archive/" branch ".zip")) -; ToDo: Move to common? (defn-spec replace-all-matching-subvalues-in-string-start pred/map-or-seq? [col pred/map-or-seq? value-to-partly-match string? diff --git a/src/main/resources/ingress/http-ingress.yaml b/src/main/resources/ingress/http-ingress.yaml index 1570032..562f17c 100644 --- a/src/main/resources/ingress/http-ingress.yaml +++ b/src/main/resources/ingress/http-ingress.yaml @@ -15,6 +15,6 @@ spec: path: "/" backend: # TODO: Review jem 2022/10/26: wo backend as we should only do a redirect here ... ? service: - name: SERVIC_ENAME + name: SERVICE_NAME port: number: 80 diff --git a/src/test/cljc/dda/c4k_website/core_test.cljc b/src/test/cljc/dda/c4k_website/core_test.cljc index dea9991..f5248ad 100644 --- a/src/test/cljc/dda/c4k_website/core_test.cljc +++ b/src/test/cljc/dda/c4k_website/core_test.cljc @@ -48,8 +48,6 @@ :username "someuser", :authtoken "abedjgbasdodj"}) -; TODO: gec 2022/10/28: This might be the desired behavior. -; cut/flatten-and-reduce-config must be fixed accordingly. (deftest test-flatten-and-reduce-config (is (= (cut/flatten-and-reduce-config (merge websites auth1))