[Skip-Ci] Remove ToDo markers
This commit is contained in:
parent
8e93644cb5
commit
16189ee9c4
4 changed files with 1 additions and 5 deletions
|
@ -18,7 +18,6 @@
|
||||||
(s/def ::service-port pos-int?)
|
(s/def ::service-port pos-int?)
|
||||||
(s/def ::fqdns (s/coll-of pred/fqdn-string?))
|
(s/def ::fqdns (s/coll-of pred/fqdn-string?))
|
||||||
|
|
||||||
; TODO: Review jem 2022/10/26: Namespace is called ingress but we do more: Ingress & cert -> rename ore mv. certificate to own ns
|
|
||||||
(def ingress? (s/keys :req-un [::fqdns ::ingress-name ::service-name ::service-port]
|
(def ingress? (s/keys :req-un [::fqdns ::ingress-name ::service-name ::service-port]
|
||||||
:opt-un [::issuer ::cert-name]))
|
:opt-un [::issuer ::cert-name]))
|
||||||
|
|
||||||
|
|
|
@ -71,7 +71,6 @@
|
||||||
branch string?]
|
branch string?]
|
||||||
(str "https://" host "/api/v1/repos/" user "/" repo "/archive/" branch ".zip"))
|
(str "https://" host "/api/v1/repos/" user "/" repo "/archive/" branch ".zip"))
|
||||||
|
|
||||||
; ToDo: Move to common?
|
|
||||||
(defn-spec replace-all-matching-subvalues-in-string-start pred/map-or-seq?
|
(defn-spec replace-all-matching-subvalues-in-string-start pred/map-or-seq?
|
||||||
[col pred/map-or-seq?
|
[col pred/map-or-seq?
|
||||||
value-to-partly-match string?
|
value-to-partly-match string?
|
||||||
|
|
|
@ -15,6 +15,6 @@ spec:
|
||||||
path: "/"
|
path: "/"
|
||||||
backend: # TODO: Review jem 2022/10/26: wo backend as we should only do a redirect here ... ?
|
backend: # TODO: Review jem 2022/10/26: wo backend as we should only do a redirect here ... ?
|
||||||
service:
|
service:
|
||||||
name: SERVIC_ENAME
|
name: SERVICE_NAME
|
||||||
port:
|
port:
|
||||||
number: 80
|
number: 80
|
||||||
|
|
|
@ -48,8 +48,6 @@
|
||||||
:username "someuser",
|
:username "someuser",
|
||||||
:authtoken "abedjgbasdodj"})
|
:authtoken "abedjgbasdodj"})
|
||||||
|
|
||||||
; TODO: gec 2022/10/28: This might be the desired behavior.
|
|
||||||
; cut/flatten-and-reduce-config must be fixed accordingly.
|
|
||||||
(deftest test-flatten-and-reduce-config
|
(deftest test-flatten-and-reduce-config
|
||||||
(is (=
|
(is (=
|
||||||
(cut/flatten-and-reduce-config (merge websites auth1))
|
(cut/flatten-and-reduce-config (merge websites auth1))
|
||||||
|
|
Loading…
Reference in a new issue