From 07169c5b3d8f6af9cf2559ac55686cf737d75a97 Mon Sep 17 00:00:00 2001 From: patdyn Date: Thu, 27 Jun 2024 14:19:27 +0200 Subject: [PATCH] Remove todos --- .../python/ddadevops/domain/backend_tf_backend_git.py | 8 ++++---- src/main/python/ddadevops/domain/terraform.py | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/main/python/ddadevops/domain/backend_tf_backend_git.py b/src/main/python/ddadevops/domain/backend_tf_backend_git.py index 2a514c6..f4a99ed 100644 --- a/src/main/python/ddadevops/domain/backend_tf_backend_git.py +++ b/src/main/python/ddadevops/domain/backend_tf_backend_git.py @@ -1,8 +1,7 @@ from typing import List, Dict, Set, Any from .common import Validateable, CredentialMappingDefault -# TODO: Add a 'git_as_backend' option -# TODO: Check this option at the right places + class TerraformBackendGit(Validateable, CredentialMappingDefault): def __init__( self, @@ -40,10 +39,11 @@ class TerraformBackendGit(Validateable, CredentialMappingDefault): def resources_from_package(self) -> Set[str]: return {"tf_backend_git_backend.tf", "tf_backend_git_backend_vars.tf"} - # TODO: This can not be used for backend config, as the backend block can not reference vars. + # TODO: This can not be used for backend, as the backend block can not reference vars. + # This is another reason to introduce a 'backend' object def project_vars(self) -> Dict[str, Any]: return { - "http_backend_address": self.__make_http_backend_address__() + "": "" } def is_local_state(self): diff --git a/src/main/python/ddadevops/domain/terraform.py b/src/main/python/ddadevops/domain/terraform.py index 2296226..980f0a6 100644 --- a/src/main/python/ddadevops/domain/terraform.py +++ b/src/main/python/ddadevops/domain/terraform.py @@ -95,7 +95,6 @@ class TerraformDomain(Validateable): return False # TODO: Add ssh method case and make this default - # TODO: How do we get to the credentials? def env_credentials(self) -> Dict[str, str]: tf_backend_git = self.providers[ProviderType.TERRAFORM_BACKEND_GIT] if tf_backend_git.git_backend_token != "":