From 39d732a04e71e23aadab4db7a62334b15f18101d Mon Sep 17 00:00:00 2001
From: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date: Fri, 26 May 2023 15:14:12 +0200
Subject: [PATCH] handle backends in project_vars

---
 .../digitalocean_backend_properties_mixin.py  |  9 -----
 .../ddadevops/domain/provider_digitalocean.py | 31 +++++++++++++----
 .../domain/test_provider_digitalocean.py      | 33 +++++++++++++++++++
 src/test/python/domain/test_terraform.py      |  2 +-
 4 files changed, 58 insertions(+), 17 deletions(-)

diff --git a/src/main/python/ddadevops/digitalocean_backend_properties_mixin.py b/src/main/python/ddadevops/digitalocean_backend_properties_mixin.py
index 61a99a9..62e55ff 100644
--- a/src/main/python/ddadevops/digitalocean_backend_properties_mixin.py
+++ b/src/main/python/ddadevops/digitalocean_backend_properties_mixin.py
@@ -10,12 +10,3 @@ def add_digitalocean_backend_properties_mixin_config(
 
 class DigitaloceanBackendPropertiesMixin():
     pass
-
-    def project_vars(self):
-        ret = super().project_vars()
-        ret.update({"account_name": self.account_name})
-        ret.update({"endpoint": self.endpoint})
-        ret.update({"bucket": self.bucket})
-        ret.update({"key": self.key})
-        ret.update({"region": self.region})
-        return ret
diff --git a/src/main/python/ddadevops/domain/provider_digitalocean.py b/src/main/python/ddadevops/domain/provider_digitalocean.py
index e8cf494..074e625 100644
--- a/src/main/python/ddadevops/domain/provider_digitalocean.py
+++ b/src/main/python/ddadevops/domain/provider_digitalocean.py
@@ -13,7 +13,7 @@ class Digitalocean(Validateable, CredentialMappingDefault):
         self.do_spaces_access_id = inp.get("do_spaces_access_id")
         self.do_spaces_secret_key = inp.get("do_spaces_secret_key")
         self.do_as_backend = inp.get("do_as_backend", False)
-        self.do_account_name = inp.get("do_account_name")
+        self.do_account_name = inp.get("do_account_name", self.stage)
         self.do_endpoint = inp.get("do_endpoint")
         self.do_bucket = inp.get("do_bucket")
         self.do_bucket_key = inp.get("do_bucket_key")
@@ -29,6 +29,7 @@ class Digitalocean(Validateable, CredentialMappingDefault):
         result += self.__validate_is_not_empty__("do_spaces_secret_key")
         result += self.__validate_is_not_none__("do_as_backend")
         if self.do_as_backend:
+            result += self.__validate_is_not_empty__("do_account_name")
             result += self.__validate_is_not_empty__("do_endpoint")
             result += self.__validate_is_not_empty__("do_bucket")
             result += self.__validate_is_not_empty__("do_region")
@@ -43,25 +44,32 @@ class Digitalocean(Validateable, CredentialMappingDefault):
         return result
 
     def project_vars(self):
-        return {
+        result = {
             "do_api_key": self.do_api_key,
             "do_spaces_access_id": self.do_spaces_access_id,
             "do_spaces_secret_key": self.do_spaces_secret_key,
         }
+        if self.do_as_backend:
+            result.update(
+                {
+                    "account_name": self.do_account_name,
+                    "endpoint": self.do_endpoint,
+                    "bucket": self.do_bucket,
+                    "key": self.__bucket_key__(),
+                    "region": self.do_region,
+                }
+            )
+        return result
 
     def backend_config(self) -> map:
         result = {}
         if self.do_as_backend:
-            if self.do_account_name and self.do_bucket_key:
-                bucket_key = f"{self.do_account_name}/{self.do_bucket_key}"
-            else:
-                bucket_key = f"{self.stage}/{self.module}"
             result = {
                 "access_key": self.do_spaces_access_id,
                 "secret_key": self.do_spaces_secret_key,
                 "endpoint": self.do_endpoint,
                 "bucket": self.do_bucket,
-                "key": bucket_key,
+                "key": self.__bucket_key__(),
                 "region": self.do_region,
             }
         return result
@@ -69,6 +77,15 @@ class Digitalocean(Validateable, CredentialMappingDefault):
     def is_local_state(self):
         return not self.do_as_backend
 
+    def __bucket_key__(self):
+        result = ""
+        if self.do_as_backend:
+            if self.do_account_name and self.do_bucket_key:
+                result = f"{self.do_account_name}/{self.do_bucket_key}"
+            else:
+                result = f"{self.stage}/{self.module}"
+        return result
+
     @classmethod
     def get_mapping_default(cls) -> List[Dict[str, str]]:
         return [
diff --git a/src/test/python/domain/test_provider_digitalocean.py b/src/test/python/domain/test_provider_digitalocean.py
index 94fe869..c4d8782 100644
--- a/src/test/python/domain/test_provider_digitalocean.py
+++ b/src/test/python/domain/test_provider_digitalocean.py
@@ -49,3 +49,36 @@ def test_should_calculate_backend_config():
         "key": "test/module",
         "region": "region",
     } == sut.backend_config()
+
+
+def test_should_calculate_project_vars():
+    sut = Digitalocean(
+        devops_config(
+            {
+                "do_as_backend": False,
+            }
+        )
+    )
+    assert {
+        "do_api_key": "api_key",
+        "do_spaces_access_id": "spaces_id",
+        "do_spaces_secret_key": "spaces_secret",
+    } == sut.project_vars()
+
+    sut = Digitalocean(
+        devops_config(
+            {
+                "do_as_backend": True,
+            }
+        )
+    )
+    assert {
+        "do_api_key": "api_key",
+        "do_spaces_access_id": "spaces_id",
+        "do_spaces_secret_key": "spaces_secret",
+        "account_name": "test",
+        "endpoint": "endpoint",
+        "bucket": "bucket",
+        "key": "test/module",
+        "region": "region",
+    } == sut.project_vars()
diff --git a/src/test/python/domain/test_terraform.py b/src/test/python/domain/test_terraform.py
index 49fd176..5633cd1 100644
--- a/src/test/python/domain/test_terraform.py
+++ b/src/test/python/domain/test_terraform.py
@@ -64,7 +64,7 @@ def test_should_calculate_project_vars():
     sut = TerraformDomain(config)
     assert {"module": "module", "stage": "test"} == sut.project_vars()
 
-    config = devops_config({})
+    config = devops_config({"do_as_backend": False,})
     sut = TerraformDomain(config)
     assert {
         "module": "module",