From 6766691ee76e6cc016908e1d200139b24428fc4d Mon Sep 17 00:00:00 2001 From: bom Date: Thu, 11 May 2023 15:20:49 +0200 Subject: [PATCH] Add review comments for version --- src/test/python/domain/test_version.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/python/domain/test_version.py b/src/test/python/domain/test_version.py index 2caee0d..6289d30 100644 --- a/src/test/python/domain/test_version.py +++ b/src/test/python/domain/test_version.py @@ -99,10 +99,12 @@ def test_should_create_major(): assert sut.to_string() == "2.0.0" def test_should_create_bump(): + # TODO: bom - 2023_05_11: Why does this not actually bump the version? version = Version.from_str("1.2.3-SNAPSHOT") sut = version.create_bump() assert sut.to_string() == "1.2.3-SNAPSHOT" + # TODO: bom - 2023_05_11: Why do we bump the minor version and not the patch? version = Version.from_str("1.2.3") sut = version.create_bump("SNAPSHOT") assert sut.to_string() == "1.3.0-SNAPSHOT"