From 8ce3c74c34cf08a5d0268167de26760c42852d33 Mon Sep 17 00:00:00 2001 From: Michael Jerger Date: Fri, 14 Jul 2023 11:43:04 +0200 Subject: [PATCH] add some todos --- src/main/python/ddadevops/infrastructure/infrastructure.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/main/python/ddadevops/infrastructure/infrastructure.py b/src/main/python/ddadevops/infrastructure/infrastructure.py index 8b66ede..89351d0 100644 --- a/src/main/python/ddadevops/infrastructure/infrastructure.py +++ b/src/main/python/ddadevops/infrastructure/infrastructure.py @@ -101,6 +101,9 @@ class ExecutionApi: output = output.rstrip() return output + # TODO: check for exception handling + # TODO: can we return the output here also? + # TODO: should we also print stderr? def execute_live(self, command: str, dry_run=False, shell=True): if dry_run: print(command) @@ -111,6 +114,7 @@ class ExecutionApi: process.stdout.close() process.wait() + # TODO: move this enhancement to execute def execute_handled(self, command: str, dry_run=False, shell=True, check=True): if dry_run: print(command)