meissa/dda-devops-build
6
1
Fork 0
Code Issues Pull requests Projects Releases 33 Packages Wiki Activity

add some todos

Browse source
This commit is contained in:
Michael Jerger 2023-07-14 11:43:04 +02:00
parent e927ec9fcf
commit 8ce3c74c34
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/main/python/ddadevops/infrastructure/infrastructure.py
View file

@ -101,6 +101,9 @@ class ExecutionApi:
output = output.rstrip() output = output.rstrip()
return output return output
# TODO: check for exception handling
# TODO: can we return the output here also?
# TODO: should we also print stderr?
def execute_live(self, command: str, dry_run=False, shell=True): def execute_live(self, command: str, dry_run=False, shell=True):
if dry_run: if dry_run:
print(command) print(command)
@ -111,6 +114,7 @@ class ExecutionApi:
process.stdout.close() process.stdout.close()
process.wait() process.wait()
# TODO: move this enhancement to execute
def execute_handled(self, command: str, dry_run=False, shell=True, check=True): def execute_handled(self, command: str, dry_run=False, shell=True, check=True):
if dry_run: if dry_run:
print(command) print(command)