From b050e9d07c87d890eae8ca6f343faeacb4cc7107 Mon Sep 17 00:00:00 2001 From: erik Date: Wed, 19 Apr 2023 12:33:36 +0200 Subject: [PATCH] Fix CI: Correctly validate --- .../python/ddadevops/application/release_mixin_services.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/python/ddadevops/application/release_mixin_services.py b/src/main/python/ddadevops/application/release_mixin_services.py index b953e11..f5684df 100644 --- a/src/main/python/ddadevops/application/release_mixin_services.py +++ b/src/main/python/ddadevops/application/release_mixin_services.py @@ -10,8 +10,7 @@ class PrepareReleaseService(): self.git_api = GitApi() def __write_and_commit_version(self, version: Version, commit_message: str): - # TODO: isValid is missing - self.release.validate(self.release_repo.main_branch) + self.release.is_valid(self.release_repo.main_branch) self.release_repo.version_repository.write_file(version.get_version_string()) self.git_api.add_file(self.release_repo.version_repository.file) @@ -33,8 +32,7 @@ class TagAndPushReleaseService(): def tag_release(self): annotation = 'v' + self.release.version.get_version_string() message = 'Release ' + annotation - # TODO: Why is the count a parameter? We always tag the second last commit in this process. - self.git_api.tag_annotated(annotation, message, 1) + self.git_api.tag_annotated_second_last(annotation, message) def push_release(self): self.git_api.push()