meissa/dda-devops-build
6
1
Fork 0
Code Issues Pull requests Projects Releases 33 Packages Wiki Activity

All upper case TODO

Browse source
This commit is contained in:
patdyn 2024-06-27 11:39:45 +02:00
parent a6b6a6b8bc
commit de23855d65
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/main/python/ddadevops/devops_terraform_build.py
View file

@ -14,7 +14,7 @@ class DevopsTerraformBuild(DevopsBuild):
super().__init__(project, inp) super().__init__(project, inp)
project.build_depends_on("dda-python-terraform") project.build_depends_on("dda-python-terraform")
self.terraform_service = TerraformService.prod() self.terraform_service = TerraformService.prod()
# ToDo: we might want to make this private in the future, keeping this for compatibility # TODO: we might want to make this private in the future, keeping this for compatibility
def initialize_build_dir(self): def initialize_build_dir(self):
super().initialize_build_dir() super().initialize_build_dir()
devops = self.devops_repo.get_devops(self.project) devops = self.devops_repo.get_devops(self.project)

2
src/main/python/ddadevops/domain/provider_tf_backend_git.py
View file

@ -38,7 +38,7 @@ class TerraformBackendGit(Validateable, CredentialMappingDefault):
def resources_from_package(self) -> List[str]: def resources_from_package(self) -> List[str]:
return {"tf_backend_git_backend.tf", "tf_backend_git_backend_vars.tf"} return {"tf_backend_git_backend.tf", "tf_backend_git_backend_vars.tf"}
# ToDo: This can not be used for backend config, as the backend block can not reference vars. # TODO: This can not be used for backend config, as the backend block can not reference vars.
def project_vars(self) -> Dict[str, Any]: def project_vars(self) -> Dict[str, Any]:
return { return {
"http_backend_address": self.__make_http_backend_address__(self.git_backend_ref, self.git_backend_repo, self.git_backend_state) "http_backend_address": self.__make_http_backend_address__(self.git_backend_ref, self.git_backend_repo, self.git_backend_state)

4
src/main/python/ddadevops/domain/terraform.py
View file

@ -92,8 +92,8 @@ class TerraformDomain(Validateable):
def uses_backend_git(self) -> bool: def uses_backend_git(self) -> bool:
return ProviderType.TERRAFORM_BACKEND_GIT in self.providers.keys() return ProviderType.TERRAFORM_BACKEND_GIT in self.providers.keys()
# ToDo: Add ssh method case and make this default # TODO: Add ssh method case and make this default
# ToDo: How do we get to the credentials? # TODO: How do we get to the credentials?
def env_credentials(self) -> Dict[str, str]: def env_credentials(self) -> Dict[str, str]:
tf_backend_git = self.providers[ProviderType.TERRAFORM_BACKEND_GIT] tf_backend_git = self.providers[ProviderType.TERRAFORM_BACKEND_GIT]
if tf_backend_git.git_backend_token != "": if tf_backend_git.git_backend_token != "":