From 076f940f1ff7cc075240d30179a92bdf52c006e4 Mon Sep 17 00:00:00 2001 From: Ethan Koenig Date: Sat, 11 Feb 2017 12:11:07 -0500 Subject: [PATCH] Fix logging bug Error logged everytime an assignee was removed --- models/issue.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/models/issue.go b/models/issue.go index c3f5de6429..30a6cf8a4c 100644 --- a/models/issue.go +++ b/models/issue.go @@ -775,14 +775,12 @@ func (issue *Issue) ChangeAssignee(doer *User, assigneeID int64) (err error) { } else { apiPullRequest.Action = api.HookIssueAssigned } - err = PrepareWebhooks(issue.Repo, HookEventPullRequest, apiPullRequest) - } - if err != nil { - log.Error(4, "PrepareWebhooks [is_pull: %v, remove_assignee: %v]: %v", issue.IsPull, isRemoveAssignee, err) - } else { - go HookQueue.Add(issue.RepoID) + if err := PrepareWebhooks(issue.Repo, HookEventPullRequest, apiPullRequest); err != nil { + log.Error(4, "PrepareWebhooks [is_pull: %v, remove_assignee: %v]: %v", issue.IsPull, isRemoveAssignee, err) + return nil + } } - + go HookQueue.Add(issue.RepoID) return nil }