1489 Commits (44d4863ecf3d0eb63540f4f10fa2d4760e4daa74)

Author SHA1 Message Date
Fabian Zaremba 2e7ccecfe6 Git LFS support v2 (#122)
* Import github.com/git-lfs/lfs-test-server as lfs module base

Imported commit is 3968aac269a77b73924649b9412ae03f7ccd3198

Removed:

Dockerfile CONTRIBUTING.md mgmt* script/ vendor/ kvlogger.go
.dockerignore .gitignore README.md

* Remove config, add JWT support from github.com/mgit-at/lfs-test-server

Imported commit f0cdcc5a01599c5a955dc1bbf683bb4acecdba83

* Add LFS settings

* Add LFS meta object model

* Add LFS routes and initialization

* Import github.com/dgrijalva/jwt-go into vendor/

* Adapt LFS module: handlers, routing, meta store

* Move LFS routes to /user/repo/info/lfs/*

* Add request header checks to LFS BatchHandler / PostHandler

* Implement LFS basic authentication

* Rework JWT secret generation / load

* Implement LFS SSH token authentication with JWT

Specification: https://github.com/github/git-lfs/tree/master/docs/api

* Integrate LFS settings into install process

* Remove LFS objects when repository is deleted

Only removes objects from content store when deleted repo is the only
referencing repository

* Make LFS module stateless

Fixes bug where LFS would not work after installation without
restarting Gitea

* Change 500 'Internal Server Error' to 400 'Bad Request'

* Change sql query to xorm call

* Remove unneeded type from LFS module

* Change internal imports to code.gitea.io/gitea/

* Add Gitea authors copyright

* Change basic auth realm to "gitea-lfs"

* Add unique indexes to LFS model

* Use xorm count function in LFS check on repository delete

* Return io.ReadCloser from content store and close after usage

* Add LFS info to runWeb()

* Export LFS content store base path

* LFS file download from UI

* Work around git-lfs client issue with unauthenticated requests

Returning a dummy Authorization header for unauthenticated requests
lets git-lfs client skip asking for auth credentials
See: https://github.com/github/git-lfs/issues/1088

* Fix unauthenticated UI downloads from public repositories

* Authentication check order, Finish LFS file view logic

* Ignore LFS hooks if installed for current OS user

Fixes Gitea UI actions for repositories tracking LFS files.
Checks for minimum needed git version by parsing the semantic version
string.

* Hide LFS metafile diff from commit view, marking as binary

* Show LFS notice if file in commit view is tracked

* Add notbefore/nbf JWT claim

* Correct lint suggestions - comments for structs and functions

- Add comments to LFS model
- Function comment for GetRandomBytesAsBase64
- LFS server function comments and lint variable suggestion

* Move secret generation code out of conditional

Ensures no LFS code may run with an empty secret

* Do not hand out JWT tokens if LFS server support is disabled
8 years ago
Philip Couling d4924d45d6 Implement sendmail (#355)
* Implemented sendmail. This piggybacks on existing configuration to keep the change simple

* Changed privicy of new sendSMTP and sendSendmail functions

* Fixed Lint errors

* Seperated SMTP and sendmail into their own senders

* Making new structs private as they should not be used externally now

* Added sendmail setting to ini file

* Minor code cleanup
8 years ago
Bwko fa3abc22c0 Added sorting to organizations, repos & users page (#222) 8 years ago
Bwko a345a03d99 Added sorting to the labels & milestones page (#199) 8 years ago
Ethan Koenig d0932ef147 Bug fixes for Issues filters (#413)
Correctly handle simultaneous assignee/poster filters, and conflicting assignee filters
8 years ago
Ethan Koenig 8a4161c723 API Endpoint for watching (#191) 8 years ago
btrepp 25b5ffb6af Enables mssql support (#383)
* Enables mssql support

Port of dlobs work in gogs.
Enables options in index.js
Enables MSSQL as a database option in go.
Sets ID to 0 on initial migration. Required for
MSSQL insert statements.

Signed-off-by: Beau Trepp <beautrepp@gmail.com>

* Vendors in denisenkom/go-mssqldb

Includes golang.org/x/crypto/md4
as this is required by go-msssqldb

Signed-off-by: Beau Trepp <beautrepp@gmail.com>
8 years ago
Lunny Xiao a822bba3e1 Add default values for settings (#455)
* add default values for settings

* more default values

* more default settings and labels resource

* mv locale to options
8 years ago
Thomas Boerger b33078fa33 Bindata is optional and over-writable on restart (#354)
* Moved conf assets into options folder

* Dropped old bindata

* Started to integrate options bindata and accessors

* Do not enforce a builtin app.ini

* Replaced bindata calls with options

* Dropped bindata task from makefile, it's the generate task now

* Always embedd app.ini to provide sane config defaults

* Use sane defaults for the configuration

* Defined default value for SSH_KEYGEN_PATH

* Dropped "NEVER EVER MODIFY THIS FILE" header from app.ini

* Fixed new paths in latest test additions

* Drop bindata with make clean task

* Set more proper default values
8 years ago
Lunny Xiao c21e2c4151 fix tag webhook 404 error (#420) 8 years ago
Lunny Xiao 47a7529d96 update code.gitea.io/git (#450) 8 years ago
Lunny Xiao 0c5c34d7dd UpdateIssueUsersByMentions was calling database write operations while (#443)
a transaction session was in progress. MailParticipants was failing
silently because of the SQLITE_LOCKED error. Make sure failures in
MailParticipants enter the log, and pass on the transaction context.

issue: let caller pass in database context, and use it
issue_comment: obtain database context to pass to UpdateIssueMentions
issue_comment: log any error from call to MailParticipants
issue_mail: pass on database context to UpdateIssueMentions
8 years ago
Ethan Koenig 4c89a9c33c Bug fixes and tests for modules/base (#442)
Also address other TODOs
8 years ago
Kim "BKC" Carlbäcker df7fa4e995 issue comment api fix (#449)
* ListAllInRepo & Delete Issue-Comments

* Moar data in issue-comments
8 years ago
Alexander Lunegov d5d21b67d2 Fix string format verbs (#3637) 8 years ago
Denis Denisov 380e32e129 Fix random string generator (#384)
* Remove unused custom-alphabet feature of random string generator

Fix random string generator

Random string generator should return error if it fails to read random data via crypto/rand

* Fixes variable (un)initialization mixed assign
Update test GetRandomString
8 years ago
Michael de Wit 1d30457a94 change test mail subject and body to 'Gitea Test Mail!'
Signed-off-by: Michael de Wit <mjwwit@gmail.com>
8 years ago
Lunny Xiao 7c46667e71 fixed vulnerabilities labels (#409) 8 years ago
Richie B2B 44428fdc38 Remove fixed FIXME (#408) 8 years ago
Richie B2B 0d6e88baef Fix typo (#407) 8 years ago
Lunny Xiao 15c3d14d55 fixed vulnerabilities on deleting release (#399) 8 years ago
Lunny Xiao b4c794058a fixed vulnerabilities (#392) 8 years ago
Lunny Xiao d771e978a1 Don't use custom PBKDF2 function (#382) 8 years ago
Lunny Xiao 73710c00a8 bug fixed branch name for pushupdate (#380) 8 years ago
Denis Denisov f0a989c1d0 Correction LDAP validation (#342)
* Correction LDAP username validation

As https://msdn.microsoft.com/en-us/library/aa366101(v=vs.85).aspx describe spaces should not be in start or at the end of username but they can be inside the username. So please check my solution for it.

* Check for zero length passwords in LDAP module.

According to https://tools.ietf.org/search/rfc4513#section-5.1.2 LDAP client should always check before bind whether a password is an empty value. There are at least one LDAP implementation which does not return error if you try to bind with DN set and empty password - AD.

* Clearing the login/email spaces at the [start/end]
8 years ago
Bwko abcd39f7d5 In the wiki title replace tab with a space (#371) 8 years ago
Bwko cbcb4361d5 Fixes issue #283
Delete old temp local copy before we create a new temp local copy
8 years ago
Ethan Koenig 401a8db0ed Remove stale comment in models/repo.go (#366) 8 years ago
Ethan Koenig 04b9a7e7a2 Bug fixes for repo permissions in API
Also move duplicated code into repo.APIFormat(..)
8 years ago
Thomas Boerger 83ed234472 Integrate templates into bindata optionally (#314)
Integrated optional bindata for the templates
8 years ago
Kim "BKC" Carlbäcker d07c955e2a Fix regression in PR-API #248 (#349)
* Fix #344 (regression in PR-API #248)
8 years ago
Bwko 0118b275b6 Fix for #320
Suppress the error when we're removing a file that may not exist
8 years ago
Denis Denisov c8f300b2cd Safe compare password (timing attack) (#338) 8 years ago
Kim "BKC" Carlbäcker 0f05470cb8 [API] Pull Requests (#248) 8 years ago
Kim "BKC" Carlbäcker e8e0539b45 Linting 8 years ago
Kim "BKC" Carlbäcker e6cfccdd40 GitHub API Compliance (& linting) 8 years ago
Bwko 4ff0db0246 Catch os... errors 8 years ago
Bwko 5ab85372da Added rel="noopener" to target="_blank" hrefs (#327)
* Added rel="noopener" to target="_blank" hrefs

* Replaced gogs.io/docs with docs.gitea.io
8 years ago
Lunny Xiao 646e02b521 typo 8 years ago
Thomas Boerger 6dd2c3b2db
Fixed linting errors for variable definitions 8 years ago
Kim "BKC" Carlbäcker 42ec5ce740 Fix breakage from vendor-update 8 years ago
Kim "BKC" Carlbäcker dad806d3ea CreateBranch-hook has shasum. Use the full ref for fetching shasum 8 years ago
Kim "BKC" Carlbäcker f364522468 Tag-webhooks are useless without shasums 8 years ago
Andrey Nering fd53028139 Merge pull request #294 from Bwko/Lint/user.go
Lint models/user.go
8 years ago
Bwko bad1bc6518 Lint models/repo.go 8 years ago
Bwko a5aae1c145 Lint models/repo_* 8 years ago
Bwko 9963d61233 Lint models/user.go 8 years ago
Lunny Xiao 27d66855eb golint fixed for models/migrations (#291) 8 years ago
Lunny Xiao 1d0f811399 golint fixed for models/pull.go (#292) 8 years ago
Lunny Xiao 9fc609ce17 golint fixed for models/issue_comment.go 8 years ago
Thomas Boerger 9948f0daaa Merge pull request #285 from lunny/lunny/golint_models_org_team
Golint for models/org_team.go
8 years ago
Lunny Xiao f215d78157 rename all uID -> userID on models/org_team.go 8 years ago
Lunny Xiao bf8d90c5cc golint fixed for models/models.go (#284) 8 years ago
Lunny Xiao 21846d16e5 golint for models/org_team.go 8 years ago
Lunny Xiao ec87a75c00 golint fixed for modules/auth 8 years ago
Bwko a4ece1f223 Fixes typos 8 years ago
Thomas Boerger 5efdccd1d8 Merge pull request #264 from Bwko/lint/org.go
Lint models/org.go
8 years ago
Thomas Boerger 9a984c0d49 Merge pull request #266 from Bwko/lint/repo_mirror
Lint models/repo_mirror.go
8 years ago
Thomas Boerger fe3908d099 Merge pull request #268 from Bwko/lint/repo_branch
Lint models/repo_branch.go
8 years ago
Thomas Boerger e23a9d22e5 Merge pull request #267 from Bwko/lint/ssh_key
Lint models/ssh_key.go
8 years ago
Thomas Boerger 93d527a0a4 Merge pull request #265 from Bwko/lint/access.go
Lint models/access.go
8 years ago
Thomas Boerger 8347a55cc2 Merge pull request #263 from Bwko/lint/user_email
Lint models/user_email.go
8 years ago
Lunny Xiao 94da472717 Golint fixed for modules/setting (#262)
* golint fixed for modules/setting

* typo fixed and renamed UNIXSOCKET to UnixSocket
8 years ago
Bwko 0b9cf10340 Lint models/org.go & models.go 8 years ago
Bwko 7bf7042013 Lint models/repo_mirror.go 8 years ago
Bwko ce8c9ef580 Lint models/repo_branch.go 8 years ago
Bwko 6cde041080 Lint models/ssh_key.go 8 years ago
Bwko 2bb1601d7c Lint models/access.go 8 years ago
Bwko 066f515a47 Lint models/user_email.go 8 years ago
Thomas Boerger 574e49c854 Merge pull request #241 from Bwko/lint/admin.go
Lint models/admin.go
8 years ago
Thomas Boerger 21b7d30174 Merge pull request #245 from Bwko/lint/update&slack
Lint models/update.go, release.go & webhook_slack.go
8 years ago
Thomas Boerger e9c6053b86 Merge pull request #246 from Bwko/fix/typo
Fix typos
8 years ago
Thomas Boerger 3e6f363471 Merge pull request #256 from lunny/lunny/golint_modules_avatar
Golint fixed for modules/avatar
8 years ago
Thomas Boerger 7c5de1e393 Merge pull request #250 from lunny/lunny/golint_modules_markdown
Golint fixed for modules/markdown
8 years ago
Lunny Xiao 3c87c57d96 golint fixed for modules/avatar 8 years ago
Bwko c0ca6644ad Lint/issue &mail (#243)
* Lint models/release.go

* Lint models/ issue_label, issue_mail & mail.go
8 years ago
Bwko 081c2a9395 Lint models/token.go (#244) 8 years ago
Lunny Xiao 76604d8f90 fixed test build error 8 years ago
Bwko 33a2ac3830 Lint models/update.go & webhook_slack.go 8 years ago
Lunny Xiao 304bbd3f25 golint fixed for modules/markdown 8 years ago
Bwko d8e11a8eaa Lint models/admin.go 8 years ago
Bwko ece19f4a5e Lint models/release.go 8 years ago
Lunny Xiao 450969c158 test database is connect OK after db config initialized (#239) 8 years ago
Sandro Santilli 1c3044b873 Lint models/login_source.go 8 years ago
Thomas Boerger 0a66c2a2d9 Merge pull request #234 from strk/issue-lint
Lint issue.go
8 years ago
Thomas Boerger e512411863 Merge pull request #233 from strk/git_diff-lint
Lint git_diff.go
8 years ago
Thomas Boerger 03b6880089 Merge pull request #232 from strk/error-lint
Lint error.go
8 years ago
Sandro Santilli 8aa960f129 Actually document the missing bits 8 years ago
Sandro Santilli 3fba29c571 Expand documentations 8 years ago
Sandro Santilli 0a61d54a9c Expand documentation a bit more 8 years ago
Sandro Santilli dd9d0f3732 Lint action.go 8 years ago
Sandro Santilli 170f2e98cc Lint error.go
This was done semi-programmatically, not really documenting anything
8 years ago
Sandro Santilli 6e644726d0 Lint git_diff.go
Semi-automatic linting (don't really document things)
8 years ago
Sandro Santilli 4dd1eb57bd Lint issue.go 8 years ago
stroucki 3a3782bb7f Handle ssh key import better (#224)
* Handle user ssh key input better

ssh_key: when user submitted keys had a newline at the end, strings.Split
would have created a slice with an empty last element, and the key type
check would be incorrect. Perhaps a better way is to look for 'ssh-rsa' or
'ssh-dsa' at the beginning of the string, but this is simple.

* ssh_key: correct indentation
8 years ago
Sandro Santilli c25063d834 Lint webhook.go, unexports simpleMarshalJSON (#198) 8 years ago
Bwko 2a449bd4b1 Fix typos 8 years ago
Ethan Koenig 0834e492c0 API endpoints for stars 8 years ago
Bo-Yi Wu d9ffe99972 fix variable assigned and not used.
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
8 years ago
Sandro Santilli 592a4ec4d3 Fix lint errors in models/wiki (just add methods docs)
See #70
8 years ago