cb50375e2b
Add more linters to improve code readability ( #19989 )
...
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003 ) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005 )
2 years ago
3f280f89e7
Update HTTP status codes to modern codes ( #18063 )
...
* 2xx/3xx/4xx/5xx -> http.Status...
* http.StatusFound -> http.StatusTemporaryRedirect
* http.StatusMovedPermanently -> http.StatusPermanentRedirect
2 years ago
a666829a37
Move user related model into models/user ( #17781 )
...
* Move user related model into models/user
* Fix lint for windows
* Fix windows lint
* Fix windows lint
* Move some tests in models
* Merge
3 years ago
c98dd7a3e0
Remove unnecessary variable assignments ( #17695 )
...
* Remove unnecessary variable assignments
As title
* enable ineffassign
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 years ago
81926d61db
Decouple unit test, remove intermediate `unittestbridge` package ( #17662 )
...
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
3 years ago
a4bfef265d
Move db related basic functions to models/db ( #17075 )
...
* Move db related basic functions to models/db
* Fix lint
* Fix lint
* Fix test
* Fix lint
* Fix lint
* revert unnecessary change
* Fix test
* Fix wrong replace string
* Use *Context
* Correct committer spelling and fix wrong replaced words
Co-authored-by: zeripath <art27@cantab.net>
3 years ago
055f6d2296
Fix "data race" in testlogger ( #9159 )
...
* Fix data race in testlogger
* Update git_helper_for_declarative_test.go
5 years ago
e59adcde65
Use httptest in integration tests ( #3080 )
7 years ago
1ec4dc6c1d
Fix so that user can still fork his own repository to owned organizations ( #2699 )
...
* Fix so that user can still fork his own repository to his organizations
* Fix to only use owned organizations
* Add integration test for forking own repository to owned organization
7 years ago
f1adaef458
Less verbose integration tests ( #2123 )
...
* Helper functions for intergration test boilerplate
7 years ago
f64c232953
Improve integration test helper functions ( #2049 )
...
Set request headers in helper functions, and new helper for requests with string-formatted URLs
7 years ago
90f9bb12c6
fix golint error and rename func for suggestion. ( #1997 )
...
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
7 years ago
ce9b86082c
Consolidate boilerplate in integration tests ( #1979 )
7 years ago
01322af2e8
Add integration test for pull-request merge ( #1912 )
7 years ago
61716bd8f7
Display URLs in integration test logs ( #1924 )
7 years ago
30a831698e
Add integration test for repository forking
7 years ago
Wim
KN4CK3R
Lunny Xiao
Gusted
wxiaoguang
zeripath
Ethan Koenig
Lauris BH
Ethan Koenig
Bo-Yi Wu
Mura Li
Mura Li