You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath 01c10a951b
Fix ssh deploy and user key constraints (#1357) (#5939)
1. A key can either be an ssh user key or a deploy key. It cannot be both.
2. If a key is a user key - it can only be associated with one user.
3. If a key is a deploy key - it can be used in multiple repositories and the permissions it has on those repositories can be different.
4. If a repository is deleted, its deploy keys must be deleted too.

We currently don't enforce any of this and multiple repositories access with different permissions doesn't work at all. This PR enforces the following constraints:

- [x] You should not be able to add the same user key as another user
- [x] You should not be able to add a ssh user key which is being used as a deploy key
- [x] You should not be able to add a ssh deploy key which is being used as a user key
- [x] If you add an ssh deploy key to another repository you should be able to use it in different modes without losing the ability to use it in the other mode.
- [x] If you delete a repository you must delete all its deploy keys.

Fix #1357
5 years ago
..
activity.go Restrict permission check on repositories and fix some problems (#5314) 6 years ago
attachment.go Log attachment blocked events (#3615) 6 years ago
branch.go branch: Trigger update when deleting branch via UI. (#5617) 6 years ago
commit.go fix commit page showing status for current default branch (#5650) 6 years ago
download.go Add raw blob endpoint to get objects by SHA ID (#5334) 6 years ago
editor.go SECURITY: protect DeleteFilePost et al with cleanUploadFileName (#5631) 6 years ago
editor_test.go fix bug on upload file name (#5571) 6 years ago
http.go Feature: Archive repos (#5009) 6 years ago
issue.go New Issue ?body= query (#5851) 6 years ago
issue_dependency.go Added dependencies for issues (#2196) (#2531) 6 years ago
issue_label.go Add label descriptions (#3662) 6 years ago
issue_label_test.go fix go vet error (#3740) 6 years ago
issue_stopwatch.go Handle refactor (#3339) 7 years ago
issue_timetrack.go Handle refactor (#3339) 7 years ago
issue_watch.go Restrict permission check on repositories and fix some problems (#5314) 6 years ago
main_test.go Unit tests for wiki routers (#3022) 7 years ago
middlewares.go Add whitespace handling to PR-comparsion (#4683) 6 years ago
milestone.go Issue is not overdue when it is on the same date #5566 (#5568) 6 years ago
pull.go Disallow empty titles (#5785) 6 years ago
pull_review.go Add comment replies (#5104) 6 years ago
release.go Feature: Archive repos (#5009) 6 years ago
release_test.go Fix missing branch in release bug (#3108) 7 years ago
repo.go Refactor repo.isBare to repo.isEmpty #5629 (#5714) 6 years ago
search.go Global code search support (#3664) 6 years ago
setting.go Fix ssh deploy and user key constraints (#1357) (#5939) 5 years ago
setting_protected_branch.go Approvals at Branch Protection (#5350) 6 years ago
settings_test.go An inactive user shouldn't be able to be added as a collaborator (#4535) 6 years ago
topic.go Fix topics addition (Another solution) (#4031) (#4258) 6 years ago
view.go Feature: Archive repos (#5009) 6 years ago
webhook.go Slack webhook channel name cannot be empty or just contain an hashtag (#4786) 6 years ago
wiki.go Feature: Archive repos (#5009) 6 years ago
wiki_test.go Improve wiki test (#3493) 6 years ago