You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/services
Eng Zer Jun 13d5d2e711
Remove redundant `len` check around loop (#27464)
This pull request is a minor code cleanup.

From the Go specification (https://go.dev/ref/spec#For_range):

> "1. For a nil slice, the number of iterations is 0."
> "3. If the map is nil, the number of iterations is 0."

`len` returns 0 if the slice or map is nil
(https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0`
before a loop is unnecessary.

---

At the time of writing this pull request, there wasn't a lint rule that
catches these issues. The closest I could find is
https://staticcheck.dev/docs/checks/#S103

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
9 months ago
..
actions Make Actions tasks/jobs timeouts configurable by the user (#27400) 9 months ago
agit Move notification interface to services layer (#26915) 10 months ago
asymkey make writing main test easier (#27270) 9 months ago
attachment Even more `db.DefaultContext` refactor (#27352) 9 months ago
auth Fix ldap admin privileges update bug (#27051) 9 months ago
automerge Improve queue and logger context (#24924) 1 year ago
context Another round of `db.DefaultContext` refactor (#27103) 9 months ago
convert Even more `db.DefaultContext` refactor (#27352) 9 months ago
cron More `db.DefaultContext` refactor (#27265) 9 months ago
externalaccount More `db.DefaultContext` refactor (#27265) 9 months ago
feed More `db.DefaultContext` refactor (#27265) 9 months ago
forms Add support for forking single branch (#25821) 9 months ago
gitdiff Even more `db.DefaultContext` refactor (#27352) 9 months ago
indexer Update status and code index after changing the default branch (#27018) 10 months ago
issue Even more `db.DefaultContext` refactor (#27352) 9 months ago
lfs Bump github.com/golang-jwt/jwt to v5 (#25975) 12 months ago
mailer Even more `db.DefaultContext` refactor (#27352) 9 months ago
markup make writing main test easier (#27270) 9 months ago
migrations Even more `db.DefaultContext` refactor (#27352) 9 months ago
mirror Even more `db.DefaultContext` refactor (#27352) 9 months ago
notify Update status and code index after changing the default branch (#27018) 10 months ago
org make writing main test easier (#27270) 9 months ago
packages Another round of `db.DefaultContext` refactor (#27103) 9 months ago
pull Remove redundant `len` check around loop (#27464) 9 months ago
release Even more `db.DefaultContext` refactor (#27352) 9 months ago
repository Even more `db.DefaultContext` refactor (#27352) 9 months ago
secrets Refactor secrets modification logic (#26873) 10 months ago
task Fix unexpected context canceled when migrating repository (#27368) 9 months ago
uinotification More `db.DefaultContext` refactor (#27265) 9 months ago
user Even more `db.DefaultContext` refactor (#27352) 9 months ago
webhook make writing main test easier (#27270) 9 months ago
wiki Even more `db.DefaultContext` refactor (#27352) 9 months ago