meissa
/
forgejo
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '0614ae1c44'
${ noResults }
forgejo/services
History
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
 		2 years ago
..
agit Add more linters to improve code readability (#19989) 2 years ago
asymkey Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
attachment Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
auth SessionUser protection against nil pointer dereference (#21358) 2 years ago
automerge Add more linters to improve code readability (#19989) 2 years ago
comments Move issues related files into models/issues (#19931) 2 years ago
context Move almost all functions' parameter db.Engine to context.Context (#19748) 2 years ago
cron Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
externalaccount Refactor auth package (#17962) 3 years ago
forms Limit length of repo description and repo url input fields (#21119) 2 years ago
gitdiff Stop logging CheckPath returns error: context canceled (#21064) 2 years ago
issue Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
lfs Move some code into models/git (#19879) 2 years ago
mailer Add generic set type (#21408) 2 years ago
migrations Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
mirror Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
org Move some files into models' sub packages (#20262) 2 years ago
packages Replace `ServeStream` with `ServeContent` (#20903) 2 years ago
pull Add generic set type (#21408) 2 years ago
release Do not send notifications for draft releases (#21451) 2 years ago
repository Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2 years ago
task Move some files into models' sub packages (#20262) 2 years ago
user Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
webhook Display total commit count in hook message (#21400) 2 years ago
wiki Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago