You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
advanced Improve clarity for camo proxy parameters (#21386) 2 years ago
developers Record OAuth client type at registration (#21316) 2 years ago
features Docs: Update the feature comparison to other Git Hosting Services (#20933) 2 years ago
help Fix the hook related FAQ contents (#21297) 2 years ago
installation Update macOS install command (#21507) 2 years ago
packages Add support for Chocolatey/NuGet v2 API (#21393) 2 years ago
translation Add markdownlint (#20512) 2 years ago
upgrade Add redirect of /upgrade/ to /upgrade-from-gitea/ on docs site (#21330) 2 years ago
usage Update reverse-proxies.zh-cn.md (#21484) 2 years ago
advanced.en-us.md Import docs into main repository (#2874) 7 years ago
advanced.fr-fr.md General documentation cleanup (#3317) 7 years ago
advanced.zh-cn.md Import docs into main repository (#2874) 7 years ago
advanced.zh-tw.md [docs] Add zh-tw Translations (#14507) 3 years ago
developers.en-us.md Add Package Registry (#16510) 2 years ago
developers.zh-cn.md Add documentation for backend development (#17512) 3 years ago
developers.zh-tw.md Add Package Registry (#16510) 2 years ago
features.en-us.md Import docs into main repository (#2874) 7 years ago
features.zh-cn.md Import docs into main repository (#2874) 7 years ago
features.zh-tw.md Import docs into main repository (#2874) 7 years ago
help.en-us.md Implement documentation search (#8937) 5 years ago
help.fr-fr.md Implement documentation search (#8937) 5 years ago
help.zh-cn.md Implement documentation search (#8937) 5 years ago
help.zh-tw.md [docs] Add zh-tw Translations (#14507) 3 years ago
installation.en-us.md Import docs into main repository (#2874) 7 years ago
installation.fr-fr.md General documentation cleanup (#3317) 7 years ago
installation.zh-cn.md Import docs into main repository (#2874) 7 years ago
installation.zh-tw.md Import docs into main repository (#2874) 7 years ago
packages.en-us.md Add Package Registry (#16510) 2 years ago
translation.de-de.md Add Package Registry (#16510) 2 years ago
translation.en-us.md Add Package Registry (#16510) 2 years ago
translation.zh-tw.md Add Package Registry (#16510) 2 years ago
upgrade.en-us.md Import docs into main repository (#2874) 7 years ago
upgrade.fr-fr.md General documentation cleanup (#3317) 7 years ago
upgrade.zh-cn.md Import docs into main repository (#2874) 7 years ago
upgrade.zh-tw.md Import docs into main repository (#2874) 7 years ago
usage.en-us.md Import docs into main repository (#2874) 7 years ago
usage.zh-cn.md ZH-CN translation of Usage part (#5086) 6 years ago
usage.zh-tw.md [docs] Add zh-tw Translations (#14507) 3 years ago