You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
This PR is extracted from #23346 to address some unclear (I don't
understand) code-belonging concerns.
This PR needs to be backported, otherwise the `aria.js` is too buggy in
some cases. Since there would be two minor conflicts, I will do the
backport manually.
Before: the `aria.js` is still buggy in some cases.
After: tested with AppleVoice, Android TalkBack
* Fix incorrect dropdown init code
* Fix incorrect role element (the menu role should be on the `$menu`
element, but not on the `$focusable`)
* Fix the focus-show-click-hide problem on mobile. Now the language menu
works as expected
* Fix incorrect dropdown template function setting
* Clarify the logic in aria.js
* Hide item's tippy after menu gets hidden
* Fix incorrect tippy `setProps` after `destroy`
* Fix UI lag problem when page gets redirected during menu hiding
animation with screen reader
* Improve comments
* Implement the layout proposed by #19861
<details>
|
1 year ago | |
---|---|---|
.. | ||
actions | 1 year ago | |
branch | 1 year ago | |
cite | 1 year ago | |
diff | 1 year ago | |
editor | 1 year ago | |
find | 1 year ago | |
graph | 1 year ago | |
issue | 1 year ago | |
migrate | 1 year ago | |
projects | 1 year ago | |
pulls | 1 year ago | |
release | 1 year ago | |
settings | 1 year ago | |
wiki | 1 year ago | |
activity.tmpl | 1 year ago | |
blame.tmpl | 1 year ago | |
branch_dropdown.tmpl | 1 year ago | |
clone_buttons.tmpl | 1 year ago | |
clone_script.tmpl | 1 year ago | |
commit_page.tmpl | 1 year ago | |
commit_status.tmpl | 1 year ago | |
commit_statuses.tmpl | 1 year ago | |
commits.tmpl | 1 year ago | |
commits_list.tmpl | 1 year ago | |
commits_list_small.tmpl | 1 year ago | |
commits_table.tmpl | 1 year ago | |
create.tmpl | 1 year ago | |
create_helper.tmpl | 1 year ago | |
empty.tmpl | 1 year ago | |
file_info.tmpl | 1 year ago | |
forks.tmpl | 1 year ago | |
graph.tmpl | 1 year ago | |
header.tmpl | 1 year ago | |
home.tmpl | 1 year ago | |
icon.tmpl | 1 year ago | |
packages.tmpl | 1 year ago | |
search.tmpl | 1 year ago | |
search_name.tmpl | 1 year ago | |
shabox_badge.tmpl | 1 year ago | |
sub_menu.tmpl | 1 year ago | |
unicode_escape_prompt.tmpl | 1 year ago | |
upload.tmpl | 2 years ago | |
user_cards.tmpl | 1 year ago | |
view_file.tmpl | 1 year ago | |
view_list.tmpl | 1 year ago | |
watchers.tmpl | 1 year ago |