meissa
/
forgejo
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '085f717529'
${ noResults }
forgejo/services
History
kolaente 085f717529
feat: notify doers of a merge when automerging (#21553) 
I found myself wondering whether a PR I scheduled for automerge was
actually merged. It was, but I didn't receive a mail notification for it
- that makes sense considering I am the doer and usually don't want to
receive such notifications. But ideally I want to receive a notification
when a PR was merged because I scheduled it for automerge.

This PR implements exactly that.

The implementation works, but I wonder if there's a way to avoid passing
the "This PR was automerged" state down so much. I tried solving this
via the database (checking if there's an automerge scheduled for this PR
when sending the notification) but that did not work reliably, probably
because sending the notification happens async and the entry might have
already been deleted. My implementation might be the most
straightforward but maybe not the most elegant.

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 		2 years ago
..
agit Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago
asymkey Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
attachment Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago
auth Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago
automerge feat: notify doers of a merge when automerging (#21553) 2 years ago
comments Move issues related files into models/issues (#19931) 2 years ago
context Move almost all functions' parameter db.Engine to context.Context (#19748) 2 years ago
cron Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
externalaccount Refactor auth package (#17962) 3 years ago
forms Configure update checker on installation page (#21655) 2 years ago
gitdiff Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
issue Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago
lfs Prevent Authorization header for presigned LFS urls (#21531) 2 years ago
mailer feat: notify doers of a merge when automerging (#21553) 2 years ago
markup Link mentioned user in markdown only if they are visible to viewer (#21554) 2 years ago
migrations Handle branch name with prefix in GitHub migration (#20357) 2 years ago
mirror Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
org Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago
packages Replace `ServeStream` with `ServeContent` (#20903) 2 years ago
pull feat: notify doers of a merge when automerging (#21553) 2 years ago
release Revert "Do not send notifications for draft releases (#21451)" (#21594) 2 years ago
repository Fix repository adoption on Windows (#21646) 2 years ago
task Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago
user Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago
webhook Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago
wiki Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2 years ago