You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Martijn de Boer 89a8b3e163
Limit max-height of CodeMirror editors for issue comment and wiki (#18271)
* Make the wiki editor bar sticky for longer wiki edits

On codeberg community it was requested to make the wiki editor toolbar sticky for longer wiki posts, so one wouldn't have to scroll to the top to use it. (Reference; https://codeberg.org/Codeberg/Community/issues/533).

In order to make this happen, the .editor-toolbar class needs to become position: sticky, and we need to fix it's transparent background and border-bottom. Because the bottom disappears, we add it. This makes the border become a double border, because the CodeMirror area defines borders for all. As such I've added a border-top: none, on the wiki write tab for the CodeMirror class.

* Make the issue bar in the issue view sticky for issue #10675

In issue #10675 it's requested to make the issue bar sticky upon scrolling in the issue view. The proposed change changes inline html, which is not desirable. As such I've added the position sticky option to it's container, and fix the background upon scrolling.

* Make linter happy on _repository.less

Fix 0px -> 0 to make the linter happy.

* Make linter happy on _editor.less

Fix 0px -> 0 to make the linter happy.

* Change z-index to the lowest boundary of 1

As per review of @silverwind change the z-index to it's lowest requirement of 1.

* Change z-index to the lowest boundary of 1

As per review of @silverwind change the z-index to it's lowest requirement of 1.

* Revert changes made to wiki editor (unsticky) and add max-height

Fixes the max-height to 85vh, on the proposed 90vh it just came out just slightly too large.
Unstickies the changes from the sticky commits.

* Revert changes for the sticky title editor

Removes the changes as done by the sticky title editor.

* Add max-height definition to CodeMirror-scroll

Add the max-height definition for the CodeMirror-scroll class in order to generalize the changes spoken about in PR #18271

* Remove CodeMirror-scroll definition

Remove the max-height in CodeMirror-scroll definition, in order to generalize it in the CodeMirror less file. As per discussion in #18271.

* fine tune CodeMirror min-height/max-height

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
chroma Make .cs highlighting legible on dark themes. (#19604) 2 years ago
code Fix and restyle menu on code line (#15913) 3 years ago
codemirror Extract CodeMirror styles (#17960) 3 years ago
features Feature: show issue assignee on project board (#15232) 2 years ago
markup Disallow selecting the text of buttons (#19330) 2 years ago
shared Show source/target branches on PR's list (#19747) 2 years ago
standalone Update JS dependencies, fix lint (#18389) 2 years ago
themes Remove fomantic progress module (#19760) 2 years ago
_admin.less Improve UI on mobile (#19546) 2 years ago
_base.less Limit max-height of CodeMirror editors for issue comment and wiki (#18271) 2 years ago
_dashboard.less Fix overflow label in mobile view (#17020) 3 years ago
_editor.less Extract CodeMirror styles (#17960) 3 years ago
_explore.less Ensure popup text is aligned left (#17327) 3 years ago
_font_i18n.less Prefer "Hiragino Kaku Gothic ProN" in system-ui-ja (#17954) 3 years ago
_form.less Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2 years ago
_home.less fix media query edge case (#13546) 4 years ago
_install.less Refactor install page (db type) (#17919) 3 years ago
_organization.less Add RSS Feed buttons to Repo, User and Org pages (#19370) 2 years ago
_repository.less Limit max-height of CodeMirror editors for issue comment and wiki (#18271) 2 years ago
_review.less Allow to mark files in a PR as viewed (#19007) 2 years ago
_svg.less Update JS dependencies, fix lint (#18389) 2 years ago
_tribute.less Update JS dependencies (#15033) 3 years ago
_user.less Improve UI on mobile (#19546) 2 years ago
animations.less Improve reviewing PR UX (#19612) 2 years ago
helpers.less Fix Pull Request comment filename word breaks (#19535) 2 years ago
index.less Various Mermaid improvements (#18776) 2 years ago
misc.css Raw file view tweaks (#15520) 3 years ago
variables.less fix media query edge case (#13546) 4 years ago