You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

wxiaoguang 0bc8bb3cc4 Make issue meta dropdown support Enter, confirm before reloading (#23014) ... As the title. Label/assignee share the same code. * Close #22607 * Close #20727 Also: * partially fix for #21742, now the comment reaction and menu work with keyboard. * partially fix for #17705, in most cases the comment won't be lost. * partially fix for #21539 * partially fix for #20347 * partially fix for #7329 ### The `Enter` support Before, if user presses Enter, the dropdown just disappears and nothing happens or the window reloads. After, Enter can be used to select/deselect labels, and press Esc to hide the dropdown to update the labels (still no way to cancel .... maybe you can do a Cmd+R or F5 to refresh the window to discard the changes .....) This is only a quick patch, the UX is still not perfect, but it's much better than before. ### The `confirm` before reloading And more fixes for the `reload` problem, the new behaviors: * If nothing changes (just show/hide the dropdown), then the page won't be reloaded. * If there are draft comments, show a confirm dialog before reloading, to avoid losing comments. That's the best effect can be done at the moment, unless completely refactor these dropdown related code. Screenshot of the confirm dialog: <details>  </details> --------- Co-authored-by: Brecht Van Lommel <brecht@blender.org> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		1 year ago
..
fields	Support Issue forms and PR forms (#20987)	2 years ago
labels	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	1 year ago
view_content	Make issue meta dropdown support Enter, confirm before reloading (#23014)	1 year ago
branch_selector_field.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	1 year ago
choose.tmpl	Add main landmark to templates and adjust titles (#22670)	1 year ago
comment_tab.tmpl	Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986)	1 year ago
label_precolors.tmpl	Fix purple color in suggested label colors (#18241)	2 years ago
labels.tmpl	Add main landmark to templates and adjust titles (#22670)	1 year ago
list.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	1 year ago
milestone_issues.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	1 year ago
milestone_new.tmpl	Add main landmark to templates and adjust titles (#22670)	1 year ago
milestones.tmpl	Move helpers to be prefixed with `gt-` (#22879)	1 year ago
navbar.tmpl	Add some headings to repo views (#22869)	1 year ago
new.tmpl	Add main landmark to templates and adjust titles (#22670)	1 year ago
new_form.tmpl	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	1 year ago
openclose.tmpl	Move helpers to be prefixed with `gt-` (#22879)	1 year ago
search.tmpl	Issues: add Project filter to issues list and search (#22544)	1 year ago
view.tmpl	Add main landmark to templates and adjust titles (#22670)	1 year ago
view_content.tmpl	Improve accessibility for issue comments (#22612)	1 year ago
view_title.tmpl	Fix pull request branch selector visible without clicking Edit (#23012)	1 year ago