You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath 0faf175694
Fix missing close in WalkGitLog (#17008)
When the external context is cancelled it is possible for the
GitLogReader to not itself be Closed.

This PR does three things:

1. Instead of adding a plain defer it wraps the `g.Close` in a func as
`g` may change.
2. It adds the missing explicit g.Close - although the defer fix makes
this unnecessary.
3. It passes down the external context as the base context for the
GitLogReader meaning that the cancellation of the external context will
pass down automatically.

Fix #17007

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years ago
..
pipeline Add bundle download for repository (#14538) 3 years ago
tests/repos Fix webhook commits wrong hash on HEAD reset (#16283) 3 years ago
README.md move code.gitea.io/git to code.gitea.io/gitea/modules/git (#6364) 5 years ago
batch_reader.go Make cancel from CatFileBatch and CatFileBatchCheck wait for the command to end (#16479) 3 years ago
blame.go Fix various documentation, user-facing, and source comment typos (#16367) 3 years ago
blame_test.go Ensure BlameReaders close at end of request (#12102) 4 years ago
blob.go Fix diff expansion is missing final line in a file (#16222) 3 years ago
blob_gogit.go Add bundle download for repository (#14538) 3 years ago
blob_nogogit.go Fix git.Blob.DataAsync(): close pipe since we return a NopCloser (#16899) 3 years ago
blob_test.go On open repository open common cat file batch and batch-check (#15667) 3 years ago
command.go Add proxy settings and support for migration and webhook (#16704) 3 years ago
command_test.go Add bundle download for repository (#14538) 3 years ago
commit.go Replace `list.List` with slices (#16311) 3 years ago
commit_convert_gogit.go Add bundle download for repository (#14538) 3 years ago
commit_info.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
commit_info_gogit.go Add bundle download for repository (#14538) 3 years ago
commit_info_nogogit.go Add bundle download for repository (#14538) 3 years ago
commit_info_test.go Make commit info cancelable (#16032) 3 years ago
commit_reader.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 3 years ago
commit_test.go Fix modified files list in webhooks when there is a space (#16288) 3 years ago
diff.go Use gitea logging module for git module (#16243) 3 years ago
diff_test.go Fix a couple of CommentAsPatch issues. (#14804) 3 years ago
error.go Fix 500 Error with branch and tag sharing the same name #15592 (#16040) 3 years ago
git.go Add agit flow support in gitea (#14295) 3 years ago
git_test.go Use gitea logging module for git module (#16243) 3 years ago
hook.go Use gitea logging module for git module (#16243) 3 years ago
last_commit_cache.go Use gitea logging module for git module (#16243) 3 years ago
last_commit_cache_gogit.go Add bundle download for repository (#14538) 3 years ago
last_commit_cache_nogogit.go Add bundle download for repository (#14538) 3 years ago
lfs.go Let package git depend on setting but not opposite (#15241) 3 years ago
log_name_status.go Fix missing close in WalkGitLog (#17008) 3 years ago
notes.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
notes_gogit.go Add bundle download for repository (#14538) 3 years ago
notes_nogogit.go Add bundle download for repository (#14538) 3 years ago
notes_test.go Change the implementation of the go-git version of GetNote to mirror the non go-git version when passed a non-existent commit (#16658) 3 years ago
parse_gogit.go Add bundle download for repository (#14538) 3 years ago
parse_gogit_test.go Add bundle download for repository (#14538) 3 years ago
parse_nogogit.go Add bundle download for repository (#14538) 3 years ago
parse_nogogit_test.go Add bundle download for repository (#14538) 3 years ago
ref.go Multiple GitGraph improvements: Exclude PR heads, Add branch/PR links, Show only certain branches, (#12766) 4 years ago
remote.go Add push to remote mirror repository (#15157) 3 years ago
repo.go Add bundle download for repository (#14538) 3 years ago
repo_archive.go Add bundle download for repository (#14538) 3 years ago
repo_attribute.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 3 years ago
repo_attribute_test.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 3 years ago
repo_base_gogit.go Add bundle download for repository (#14538) 3 years ago
repo_base_nogogit.go Add bundle download for repository (#14538) 3 years ago
repo_blame.go Removed unnecessary conversions (#7557) 5 years ago
repo_blob.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
repo_blob_gogit.go Add bundle download for repository (#14538) 3 years ago
repo_blob_nogogit.go Add bundle download for repository (#14538) 3 years ago
repo_blob_test.go On open repository open common cat file batch and batch-check (#15667) 3 years ago
repo_branch.go Add agit flow support in gitea (#14295) 3 years ago
repo_branch_gogit.go Add bundle download for repository (#14538) 3 years ago
repo_branch_nogogit.go Add bundle download for repository (#14538) 3 years ago
repo_branch_test.go [API] Add pagination to ListBranches (#14524) 3 years ago
repo_commit.go Replace `list.List` with slices (#16311) 3 years ago
repo_commit_gogit.go Add bundle download for repository (#14538) 3 years ago
repo_commit_nogogit.go Add bundle download for repository (#14538) 3 years ago
repo_commit_test.go Replace `list.List` with slices (#16311) 3 years ago
repo_commitgraph_gogit.go Add bundle download for repository (#14538) 3 years ago
repo_compare.go Replace `list.List` with slices (#16311) 3 years ago
repo_compare_test.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
repo_gpg.go Sign merges, CRUD, Wiki and Repository initialisation with gpg key (#7631) 5 years ago
repo_hook.go move code.gitea.io/git to code.gitea.io/gitea/modules/git (#6364) 5 years ago
repo_index.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 3 years ago
repo_language_stats.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
repo_language_stats_gogit.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 3 years ago
repo_language_stats_nogogit.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 3 years ago
repo_object.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
repo_ref.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
repo_ref_gogit.go Add bundle download for repository (#14538) 3 years ago
repo_ref_nogogit.go Add bundle download for repository (#14538) 3 years ago
repo_ref_test.go Add Close() method to gogitRepository (#8901) 5 years ago
repo_stats.go Fix various documentation, user-facing, and source comment typos (#16367) 3 years ago
repo_stats_test.go Add top author stats to activity page (#9615) 5 years ago
repo_tag.go [API] generalize list header (#16551) 3 years ago
repo_tag_gogit.go Add bundle download for repository (#14538) 3 years ago
repo_tag_nogogit.go Add bundle download for repository (#14538) 3 years ago
repo_tag_test.go [API] generalize list header (#16551) 3 years ago
repo_test.go Tests should use test files (#15801) 3 years ago
repo_tree.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
repo_tree_gogit.go Add bundle download for repository (#14538) 3 years ago
repo_tree_nogogit.go Add bundle download for repository (#14538) 3 years ago
sha1.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
sha1_gogit.go Add bundle download for repository (#14538) 3 years ago
sha1_nogogit.go Add bundle download for repository (#14538) 3 years ago
signature.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
signature_gogit.go Add bundle download for repository (#14538) 3 years ago
signature_nogogit.go Add bundle download for repository (#14538) 3 years ago
submodule.go Compare SSH_DOMAIN when parsing submodule URLs (#12753) 4 years ago
submodule_test.go Compare SSH_DOMAIN when parsing submodule URLs (#12753) 4 years ago
tag.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 3 years ago
tag_test.go Fix git.parseTagData (#14105) 4 years ago
tree.go Add TestPrepareWikiFileName (#16487) 3 years ago
tree_blob.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
tree_blob_gogit.go Add bundle download for repository (#14538) 3 years ago
tree_blob_nogogit.go Add bundle download for repository (#14538) 3 years ago
tree_entry.go On open repository open common cat file batch and batch-check (#15667) 3 years ago
tree_entry_gogit.go Add bundle download for repository (#14538) 3 years ago
tree_entry_mode.go Use native git variants by default with go-git variants as build tag (#13673) 4 years ago
tree_entry_nogogit.go Add bundle download for repository (#14538) 3 years ago
tree_entry_test.go Add bundle download for repository (#14538) 3 years ago
tree_gogit.go Add bundle download for repository (#14538) 3 years ago
tree_nogogit.go Add bundle download for repository (#14538) 3 years ago
utils.go Fix various documentation, user-facing, and source comment typos (#16367) 3 years ago
utils_test.go Fix ref links in issue overviews for tags (#8742) 4 years ago

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.