You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Replace #19922 , which is stale since my last review: https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506 and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546 Close #19769 Changes: 1. Use `<button>` instead of `<div>` for buttons 2. Prevent default event handler in `initGlobalButtonClickOnEnter` 3. Fix the incorrect call to `pullrequest_targetbranch_change` 4. Add a slight margin-left to the input element to make UI look better The logic in repo-issue.js is not ideal, but this PR isn't going to touch the logic. This is also an example for future developers to understand how to make buttons work properly. ### Before ![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png) ### After * Add a slight margin-left. * The `Cancel` button is focused. ![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png) Co-authored-by: techknowlogick <techknowlogick@gitea.io> |
1 year ago | |
---|---|---|
.. | ||
chroma | 2 years ago | |
code | 3 years ago | |
codemirror | 2 years ago | |
console | 2 years ago | |
features | 2 years ago | |
markup | 1 year ago | |
modules | 2 years ago | |
shared | 2 years ago | |
standalone | 2 years ago | |
themes | 2 years ago | |
_actions.less | 1 year ago | |
_admin.less | 2 years ago | |
_base.less | 1 year ago | |
_dashboard.less | 2 years ago | |
_editor.less | 3 years ago | |
_explore.less | 2 years ago | |
_font_i18n.less | 3 years ago | |
_form.less | 1 year ago | |
_home.less | 4 years ago | |
_install.less | 2 years ago | |
_organization.less | 2 years ago | |
_package.less | 2 years ago | |
_repository.less | 1 year ago | |
_review.less | 2 years ago | |
_runner.less | 1 year ago | |
_svg.less | 2 years ago | |
_tribute.less | 2 years ago | |
_user.less | 2 years ago | |
animations.less | 2 years ago | |
helpers.less | 1 year ago | |
index.less | 1 year ago | |
variables.less | 4 years ago |