You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ca905b82df
Close #23671 For the feature mentioned above, this PR append ' (comment)' to the rendered html if it is a hashcomment. After the PR, type in the following ``` pull request from other repo: http://localhost:3000/testOrg/testOrgRepo/pulls/2 pull request from this repo: http://localhost:3000/aaa/testA/pulls/2 issue comment from this repo: http://localhost:3000/aaa/testA/issues/1#issuecomment-18 http://localhost:3000/aaa/testA/pulls/2#issue-9 issue comment from other repo: http://localhost:3000/testOrg/testOrgRepo/pulls/2#issuecomment-24 http://localhost:3000/testOrg/testOrgRepo/pulls/2#issue ``` Gives: <img width="687" alt="截屏2023-03-27 13 53 06" src="https://user-images.githubusercontent.com/17645053/227852387-2b218e0d-3468-4d90-ad81-d702ddd17fd2.png"> Other than the above feature, this PR also includes two other changes: 1 Right now, the render of links from file changed tab in pull request might not be very proper, for example, if type in the following. (not sure if this is an issue or design, if not an issue, I will revert the changes). example on [try.gitea.io](https://try.gitea.io/HesterG/testrepo/pulls/1) ``` https://try.gitea.io/HesterG/testrepo/pulls/1/files#issuecomment-162725 https://try.gitea.io/HesterG/testrepo/pulls/1/files ``` it will render the following <img width="899" alt="截屏2023-03-24 15 41 37" src="https://user-images.githubusercontent.com/17645053/227456117-5eccedb7-9118-4540-929d-aee9a76de852.png"> In this PR, skip processing the link into a ref issue if it is a link from files changed tab in pull request After: type in following ``` hash comment on files changed tab: http://localhost:3000/testOrg/testOrgRepo/pulls/2/files#issuecomment-24 files changed link: http://localhost:3000/testOrg/testOrgRepo/pulls/2/files ``` Gives <img width="708" alt="截屏2023-03-27 22 09 02" src="https://user-images.githubusercontent.com/17645053/227964273-5dc06c50-3713-489c-b05d-d95367d0ab0f.png"> 2 Right now, after editing the comment area, there will not be tippys attached to `ref-issue`; and no tippy attached on preview as well. example: https://user-images.githubusercontent.com/17645053/227850540-5ae34e2d-b1d7-4d0d-9726-7701bf825d1f.mov In this PR, in frontend, make sure tippy is added after editing the comment, and to the comment on preview tab After: https://user-images.githubusercontent.com/17645053/227853777-06f56b4c-1148-467c-b6f7-f79418e67504.mov |
1 year ago | |
|---|---|---|
| .. | ||
| actions | 1 year ago | |
| activitypub | 1 year ago | |
| analyze | 2 years ago | |
| auth | 1 year ago | |
| avatar | 1 year ago | |
| base | 1 year ago | |
| cache | 1 year ago | |
| charset | 1 year ago | |
| container | 2 years ago | |
| context | 1 year ago | |
| csv | 1 year ago | |
| doctor | 1 year ago | |
| emoji | 2 years ago | |
| eventsource | 2 years ago | |
| generate | 2 years ago | |
| git | 1 year ago | |
| gitgraph | 1 year ago | |
| graceful | 2 years ago | |
| hcaptcha | 1 year ago | |
| highlight | 1 year ago | |
| hostmatcher | 2 years ago | |
| html | 2 years ago | |
| httpcache | 1 year ago | |
| httplib | 1 year ago | |
| indexer | 1 year ago | |
| issue/template | 1 year ago | |
| json | 2 years ago | |
| label | 1 year ago | |
| lfs | 1 year ago | |
| log | 1 year ago | |
| markup | 1 year ago | |
| mcaptcha | 2 years ago | |
| metrics | 1 year ago | |
| migration | 1 year ago | |
| mirror | 2 years ago | |
| nosql | 2 years ago | |
| notification | 1 year ago | |
| options | 1 year ago | |
| packages | 1 year ago | |
| paginator | 2 years ago | |
| pprof | 2 years ago | |
| private | 1 year ago | |
| process | 1 year ago | |
| proxy | 1 year ago | |
| proxyprotocol | 2 years ago | |
| public | 1 year ago | |
| queue | 1 year ago | |
| recaptcha | 2 years ago | |
| references | 1 year ago | |
| regexplru | 2 years ago | |
| repository | 1 year ago | |
| secret | 1 year ago | |
| session | 2 years ago | |
| setting | 1 year ago | |
| sitemap | 2 years ago | |
| ssh | 2 years ago | |
| storage | 1 year ago | |
| structs | 1 year ago | |
| svg | 1 year ago | |
| sync | 2 years ago | |
| system | 2 years ago | |
| templates | 1 year ago | |
| test | 1 year ago | |
| timeutil | 1 year ago | |
| translation | 1 year ago | |
| turnstile | 1 year ago | |
| typesniffer | 1 year ago | |
| updatechecker | 2 years ago | |
| upload | 2 years ago | |
| uri | 2 years ago | |
| user | 2 years ago | |
| util | 1 year ago | |
| validation | 1 year ago | |
| watcher | 2 years ago | |
| web | 1 year ago | |
| webhook | 2 years ago | |
