You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mrsdizzie 8d99ee2773
Add Organization Wide Labels (#10814)
* Add organization wide labels

Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).

This makes it possible for small organizations with many repos to use
labels effectively.

Fixes #7406

* Add migration

* remove comments

* fix tests

* Update options/locale/locale_en-US.ini

Removed unused translation string

* show org labels in issue search label filter

* Use more clear var name

* rename migration after merge from master

* comment typo

* update migration again after rebase with master

* check for orgID <=0 per guillep2k review

* fmt

* Apply suggestions from code review

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* remove unused code

* Make sure RepoID is 0 when searching orgID per code review

* more changes/code review requests

* More descriptive translation var per code review

* func description/delete comment when issue label deleted instead of hiding it

* remove comment

* only use issues in that repo when calculating number of open issues for org label on repo label page

* Add integration test for IssuesSearch API with labels

* remove unused function

* Update models/issue_label.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Use subquery in GetLabelIDsInReposByNames

* Fix tests to use correct orgID

* fix more tests

* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well

* update comment for clarity

* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition

* Don't sort repos by date in IssuesSearch API

After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45

Returns different results for MySQL than other engines. However, the similar query:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30

Returns the same results.

This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.

* linter is back!

* code review

* remove now unused option

* Fix newline at end of files

* more unused code

* update to master

* check for matching ids before query

* Update models/issue_label.go

Co-Authored-By: 6543 <6543@obermui.de>

* Update models/issue_label.go

* update comments

* Update routers/org/setting.go

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
4 years ago
..
branch Add Octicon SVG spritemap (#10107) 5 years ago
diff Fix reply on code review (#10227) 5 years ago
editor Add Octicon SVG spritemap (#10107) 5 years ago
issue Add Organization Wide Labels (#10814) 4 years ago
pulls Add Octicon SVG spritemap (#10107) 5 years ago
release Add accordion to release list and compact non-latest (#10910) 4 years ago
settings Add Matrix webhook (#10831) 4 years ago
wiki Remove unnecessary parentheses in template (#10583) 4 years ago
activity.tmpl Add Octicon SVG spritemap (#10107) 5 years ago
blame.tmpl Add Octicon SVG spritemap (#10107) 5 years ago
branch_dropdown.tmpl Add Octicon SVG spritemap (#10107) 5 years ago
commit_page.tmpl Show Signer in commit lists and add basic trust (#10425) 4 years ago
commit_status.tmpl UI: Fix overflow issues in repo (#7190) 5 years ago
commits.tmpl Add Octicon SVG spritemap (#10107) 5 years ago
commits_list.tmpl Show Signer in commit lists and add basic trust (#10425) 4 years ago
commits_table.tmpl Add Octicon SVG spritemap (#10107) 5 years ago
create.tmpl Option to set default branch at repository creation (#10803) 4 years ago
empty.tmpl Option to set default branch at repository creation (#10803) 4 years ago
forks.tmpl #3348 always use relative avatar link in the template 8 years ago
graph.tmpl Add pagination to commit graph page (#8360) 5 years ago
header.tmpl Change action GETs to POST (#10462) 4 years ago
home.tmpl Add Octicon SVG spritemap (#10107) 5 years ago
migrate.tmpl Improve migrations to support migrating milestones/labels/issues/comments/pullrequests (#6290) 5 years ago
migrating.tmpl [assets] configurable URL for static resources (#7911) 5 years ago
search.tmpl Add detected file language to code search (#10256) 5 years ago
sub_menu.tmpl Tweak language stats bar (#10487) 4 years ago
user_cards.tmpl Add Octicon SVG spritemap (#10107) 5 years ago
view_file.tmpl Render READMEs in docs/ .gitea or .github from root (#10361) 4 years ago
view_list.tmpl Fix appearance of unsigned sha box in view_list (#10543) 4 years ago
watchers.tmpl #1692 APIs: Users Followers 9 years ago