You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

oliverpool b6e81357bd Add Webhook authorization header (#20926) ... _This is a different approach to #20267, I took the liberty of adapting some parts, see below_ ## Context In some cases, a weebhook endpoint requires some kind of authentication. The usual way is by sending a static `Authorization` header, with a given token. For instance: - Matrix expects a `Bearer <token>` (already implemented, by storing the header cleartext in the metadata - which is buggy on retry #19872) - TeamCity #18667 - Gitea instances #20267 - SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this is my actual personal need :) ## Proposed solution Add a dedicated encrypt column to the webhook table (instead of storing it as meta as proposed in #20267), so that it gets available for all present and future hook types (especially the custom ones #19307). This would also solve the buggy matrix retry #19872. As a first step, I would recommend focusing on the backend logic and improve the frontend at a later stage. For now the UI is a simple `Authorization` field (which could be later customized with `Bearer` and `Basic` switches):  The header name is hard-coded, since I couldn't fine any usecase justifying otherwise. ## Questions - What do you think of this approach? @justusbunsi @Gusted @silverwind - ~~How are the migrations generated? Do I have to manually create a new file, or is there a command for that?~~ - ~~I started adding it to the API: should I complete it or should I drop it? (I don't know how much the API is actually used)~~ ## Done as well: - add a migration for the existing matrix webhooks and remove the `Authorization` logic there _Closes #19872_ Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: delvh <dev.lh@web.de>		2 years ago
..
admin	Add system setting table with cache and also add cache supports for user setting (#18058)	2 years ago
auth	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
dev	Make better use of i18n (#20096)	2 years ago
events	Improve Stopwatch behavior (#18930)	2 years ago
explore	Remove deleted repos from searchresult (#21512)	2 years ago
feed	feat: notify doers of a merge when automerging (#21553)	2 years ago
healthcheck	Update go-chi/cache to utilize Ping() (#19719)	2 years ago
misc	Fix panic in team repos API (#19431)	2 years ago
org	move invite by mail to services package (#21513)	2 years ago
repo	Add Webhook authorization header (#20926)	2 years ago
user	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
auth.go	Remove legacy `+build:` constraint (#19582)	2 years ago
auth_windows.go	Let web and API routes have different auth methods group (#19168)	2 years ago
base.go	Share HTML template renderers and create a watcher framework (#20218)	2 years ago
goget.go	Refactor legacy `unknwon/com` package, improve golangci lint (#19284)	2 years ago
home.go	Add sitemap support (#18407)	2 years ago
metrics.go	Update HTTP status codes to modern codes (#18063)	2 years ago
nodeinfo.go	Add nodeinfo endpoint for federation purposes (#16953)	3 years ago
swagger_json.go	Refactor routers directory (#15800)	3 years ago
web.go	Allow disable sitemap (#21617)	2 years ago
webfinger.go	Fix various typos (#20338)	2 years ago