You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/templates
zeripath 6e22605793
Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017)
As recognised in #21841 the rendering of plain text files is somewhat
incorrect when there are ambiguous characters as the html code is double
escaped. In fact there are several more problems here.

We have a residual isRenderedHTML which is actually simply escaping the
file - not rendering it. This is badly named and gives the wrong
impression.

There is also unusual behaviour whether the file is called a Readme or
not and there is no way to get to the source code if the file is called
README.

In reality what should happen is different depending on whether the file
is being rendered a README at the bottom of the directory view or not.

1. If it is rendered as a README on a directory - it should simply be
escaped and rendered as `<pre>` text.
2. If it is rendered as a file then it should be rendered as source
code.

This PR therefore does:
1. Rename IsRenderedHTML to IsPlainText
2. Readme files rendered at the bottom of the directory are rendered
without line numbers
3. Otherwise plain text files are rendered as source code.

Replace #21841

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
1 year ago
..
admin Fix sorting admin user list by last login (#22081) 1 year ago
api/packages/pypi Add Package Registry (#16510) 2 years ago
base Optimize html templates (#22080) 2 years ago
code Run `make fmt` (#21437) 2 years ago
custom Add footer extra links template (#9576) 4 years ago
explore Optimize html templates (#22080) 2 years ago
mail Add team member invite by email (#20307) 2 years ago
org Rename almost all Ctx functions (#22071) 2 years ago
package Add package registry cleanup rules (#21658) 2 years ago
repo Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017) 1 year ago
shared Timeline and color tweaks (#21799) 2 years ago
status Remove fomantic image module (#21145) 2 years ago
swagger Add API management for issue/pull and comment attachments (#21783) 2 years ago
user Fix margin and alignment in dashboard repolist (#22120) 1 year ago
home.tmpl fix(web): add `alt` for logo in home page (#21887) 2 years ago
install.tmpl Clean up formatting on install page (#21668) 2 years ago
post-install.tmpl Rename StaticUrlPrefix to AssetUrlPrefix (#15779) 3 years ago