You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath 9c9c3348bb
Prevent NPE on commenting on lines with invalidated comments (with migration) (#12549)
* Prevent NPE on commenting on lines with invalidated comments

Only check for a review if we are replying to a previous review.

Prevent the NPE in #12239 by assuming that a comment without a Review is
non-pending.

Fix #12239

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add hack around to show the broken comments

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add migration and remove template hacks

Signed-off-by: Andrew Thornton <art27@cantab.net>
4 years ago
..
check.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
check_test.go Only check for conflicts/merging if the PR has not been merged in the interim (#10132) 4 years ago
commit_status.go Fix bug on pull view when required status check no ci result (#10648) 4 years ago
lfs.go Add basic repository lfs management (#7199) 5 years ago
main_test.go Move some pull request functions from models to services (#9266) 5 years ago
merge.go Default empty merger list to those with write permissions (#12535) 4 years ago
patch.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
pull.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
pull_test.go Move PushToBaseRepo from models to services/pull (#9352) 5 years ago
review.go Prevent NPE on commenting on lines with invalidated comments (with migration) (#12549) 4 years ago
temp_repo.go Handle more pathological branch and tag names (#11843) 4 years ago
update.go Check Push permissions on IsUserAllowedToUpdate (#11448) 4 years ago