You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

oliverpool b6e81357bd Add Webhook authorization header (#20926) ... _This is a different approach to #20267, I took the liberty of adapting some parts, see below_ ## Context In some cases, a weebhook endpoint requires some kind of authentication. The usual way is by sending a static `Authorization` header, with a given token. For instance: - Matrix expects a `Bearer <token>` (already implemented, by storing the header cleartext in the metadata - which is buggy on retry #19872) - TeamCity #18667 - Gitea instances #20267 - SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this is my actual personal need :) ## Proposed solution Add a dedicated encrypt column to the webhook table (instead of storing it as meta as proposed in #20267), so that it gets available for all present and future hook types (especially the custom ones #19307). This would also solve the buggy matrix retry #19872. As a first step, I would recommend focusing on the backend logic and improve the frontend at a later stage. For now the UI is a simple `Authorization` field (which could be later customized with `Bearer` and `Basic` switches):  The header name is hard-coded, since I couldn't fine any usecase justifying otherwise. ## Questions - What do you think of this approach? @justusbunsi @Gusted @silverwind - ~~How are the migrations generated? Do I have to manually create a new file, or is there a command for that?~~ - ~~I started adding it to the API: should I complete it or should I drop it? (I don't know how much the API is actually used)~~ ## Done as well: - add a migration for the existing matrix webhooks and remove the `Authorization` logic there _Closes #19872_ Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: delvh <dev.lh@web.de>		2 years ago
..
agit	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
asymkey	Refactor AssertExistsAndLoadBean to use generics (#20797)	2 years ago
attachment	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
auth	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
automerge	feat: notify doers of a merge when automerging (#21553)	2 years ago
comments	Move issues related files into models/issues (#19931)	2 years ago
context	Move almost all functions' parameter db.Engine to context.Context (#19748)	2 years ago
cron	Refactor git command arguments and make all arguments to be safe to be used (#21535)	2 years ago
externalaccount	Refactor auth package (#17962)	3 years ago
forms	Add Webhook authorization header (#20926)	2 years ago
gitdiff	Refactor git command arguments and make all arguments to be safe to be used (#21535)	2 years ago
issue	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
lfs	Prevent Authorization header for presigned LFS urls (#21531)	2 years ago
mailer	feat: notify doers of a merge when automerging (#21553)	2 years ago
markup	Link mentioned user in markdown only if they are visible to viewer (#21554)	2 years ago
migrations	Handle branch name with prefix in GitHub migration (#20357)	2 years ago
mirror	Refactor git command arguments and make all arguments to be safe to be used (#21535)	2 years ago
org	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
packages	Replace `ServeStream` with `ServeContent` (#20903)	2 years ago
pull	feat: notify doers of a merge when automerging (#21553)	2 years ago
release	Revert "Do not send notifications for draft releases (#21451)" (#21594)	2 years ago
repository	Fix repository adoption on Windows (#21646)	2 years ago
task	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
user	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
webhook	Add Webhook authorization header (#20926)	2 years ago
wiki	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago