You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
wxiaoguang 59d060622d
Improve RSS (#24335)
Follow  #22719

### Major changes

1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`


Screenshot of changed parts:

<details>


![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png)


![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png)


![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png)

</details>


### Other thoughts

Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
..
actions default show closed actions list if all actions was closed (#24234) 1 year ago
activity.go Implement FSFE REUSE for golang files (#21840) 2 years ago
attachment.go Make Release Download URLs predictable (#23891) 1 year ago
blame.go Sort repo topic labels by name (#24123) 1 year ago
branch.go Improve RSS (#24335) 1 year ago
cherry_pick.go Rename almost all Ctx functions (#22071) 2 years ago
commit.go Introduce GitHub markdown editor, keep EasyMDE as fallback (#23876) 1 year ago
compare.go Don't list root repository on compare page if pulls not allowed (#24183) 1 year ago
download.go Use context parameter in models/git (#22367) 2 years ago
editor.go Allow adding new files to an empty repo (#24164) 1 year ago
editor_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
find.go Implement FSFE REUSE for golang files (#21840) 2 years ago
helper.go Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890) 1 year ago
helper_test.go Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890) 1 year ago
http.go Fix incorrect CORS response in Http Git handler (#24303) 1 year ago
http_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
issue.go Show commit history for closed/merged PRs (#24238) 1 year ago
issue_content_history.go Move helpers to be prefixed with `gt-` (#22879) 1 year ago
issue_dependency.go Add API to manage issue dependencies (#17935) 1 year ago
issue_label.go Make label templates have consistent behavior and priority (#23749) 1 year ago
issue_label_test.go Make label templates have consistent behavior and priority (#23749) 1 year ago
issue_lock.go Fix improper HTMLURL usages in Go code (#22839) 1 year ago
issue_stopwatch.go Speed up HasUserStopwatch & GetActiveStopwatch (#23051) 1 year ago
issue_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
issue_timetrack.go Fix improper HTMLURL usages in Go code (#22839) 1 year ago
issue_watch.go Fix improper HTMLURL usages in Go code (#22839) 1 year ago
lfs.go Introduce path Clean/Join helper functions (#23495) 1 year ago
main_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
middlewares.go Use graceful editorconfig loader to reduce errors when loading malformed editorconfigs (#21257) 1 year ago
migrate.go Implement FSFE REUSE for golang files (#21840) 2 years ago
milestone.go Rename almost all Ctx functions (#22071) 2 years ago
packages.go Use dynamic package type list (#22263) 2 years ago
patch.go Redirect to the commit page after applying patch (#23056) 1 year ago
projects.go Add unset default project column (#23531) 1 year ago
projects_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
pull.go Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890) 1 year ago
pull_review.go Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (#23245) 1 year ago
release.go Add tags list for repos whose release setting is disabled (#23465) 1 year ago
release_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
render.go Implement FSFE REUSE for golang files (#21840) 2 years ago
repo.go Make Release Download URLs predictable (#23891) 1 year ago
runners.go Implement actions (#21937) 1 year ago
search.go Fix improper HTMLURL usages in Go code (#22839) 1 year ago
setting.go Use context parameter in services/repository (#23186) 1 year ago
setting_protected_branch.go Use context parameter in services/repository (#23186) 1 year ago
setting_secrets.go Only delete secrets belonging to its owner (#24284) 1 year ago
settings_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
tag.go Add main landmark to templates and adjust titles (#22670) 1 year ago
topic.go Implement FSFE REUSE for golang files (#21840) 2 years ago
treelist.go Implement FSFE REUSE for golang files (#21840) 2 years ago
view.go Add RSS Feeds for branches and files (#22719) 1 year ago
view_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
webhook.go Add user webhooks (#21563) 1 year ago
wiki.go Make wiki title supports dashes and improve wiki name related features (#24143) 1 year ago
wiki_test.go Make wiki title supports dashes and improve wiki name related features (#24143) 1 year ago