You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/models
zeripath 0b4a8be26b
Ensure that restricted users can access repos for which they are members (#17460)
There is a small bug in the way that repo access is checked in
repoAssignment: Accessibility is checked by checking if the user has a
marked access to the repository instead of checking if the user has any
team granted access.

This PR changes this permissions check to use HasAccess() which does the
correct test. There is also a fix in the release api ListReleases where
it should return draft releases if the user is a member of a team with
write access to the releases.

The PR also adds a testcase.

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years ago
..
appstate Sync gitea app path for git hooks and authorized keys when starting (#17335) 3 years ago
avatars Avatar refactor, move avatar code from `models` to `models.avatars`, remove duplicated code (#17123) 3 years ago
db Use a variable but a function for IsProd because of a slight performance increment (#17368) 3 years ago
fixtures Ensure that restricted users can access repos for which they are members (#17460) 3 years ago
issues Fix history count failure (#17351) 3 years ago
login Move session to models/login (#17338) 3 years ago
migrations Refactor update checker to use AppState (#17387) 3 years ago
access.go Nicely handle missing user in collaborations (#17049) 3 years ago
access_test.go DBContext is just a Context (#17100) 3 years ago
action.go DBContext is just a Context (#17100) 3 years ago
action_list.go DBContext is just a Context (#17100) 3 years ago
action_test.go Move db related basic functions to models/db (#17075) 3 years ago
admin.go Fix problem when database ID is not incremented as expected (#17229) 3 years ago
admin_test.go Move db related basic functions to models/db (#17075) 3 years ago
attachment.go DBContext is just a Context (#17100) 3 years ago
attachment_test.go DBContext is just a Context (#17100) 3 years ago
branches.go Add a simple way to rename branch like gh (#15870) 3 years ago
branches_test.go Add a simple way to rename branch like gh (#15870) 3 years ago
commit.go Replace `list.List` with slices (#16311) 3 years ago
commit_status.go Move login related structs and functions to models/login (#17093) 3 years ago
commit_status_test.go Move login related structs and functions to models/login (#17093) 3 years ago
consistency.go DBContext is just a Context (#17100) 3 years ago
consistency_test.go DBContext is just a Context (#17100) 3 years ago
engine_test.go DBContext is just a Context (#17100) 3 years ago
error.go Move twofactor to models/login (#17143) 3 years ago
error_oauth2.go gofmt (#1662) 7 years ago
external_login_user.go Move login related structs and functions to models/login (#17093) 3 years ago
fixture_generation.go DBContext is just a Context (#17100) 3 years ago
fixture_test.go refactor: move from io/ioutil to io and os package (#17109) 3 years ago
gpg_key.go Move login related structs and functions to models/login (#17093) 3 years ago
gpg_key_add.go Handle duplicate keys on GPG key ring (#17242) 3 years ago
gpg_key_commit_verification.go Move login related structs and functions to models/login (#17093) 3 years ago
gpg_key_common.go Add option to provide signature for a token to verify key ownership (#14054) 3 years ago
gpg_key_import.go DBContext is just a Context (#17100) 3 years ago
gpg_key_test.go Move db related basic functions to models/db (#17075) 3 years ago
gpg_key_verify.go DBContext is just a Context (#17100) 3 years ago
helper.go Create doctor command to fix repo_units broken by dumps from 1.14.3-1.14.6 (#17136) 3 years ago
helper_directory.go refactor: move from io/ioutil to io and os package (#17109) 3 years ago
helper_environment.go chore(models): rewrite code format. (#14754) 3 years ago
issue.go Fix issue content history problems, improve UI (#17404) 3 years ago
issue_assignees.go DBContext is just a Context (#17100) 3 years ago
issue_assignees_test.go Move db related basic functions to models/db (#17075) 3 years ago
issue_comment.go Save and view issue/comment content history (#16909) 3 years ago
issue_comment_list.go DBContext is just a Context (#17100) 3 years ago
issue_comment_test.go Move db related basic functions to models/db (#17075) 3 years ago
issue_dependency.go DBContext is just a Context (#17100) 3 years ago
issue_dependency_test.go Move db related basic functions to models/db (#17075) 3 years ago
issue_label.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_label_test.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_list.go DBContext is just a Context (#17100) 3 years ago
issue_list_test.go Move db related basic functions to models/db (#17075) 3 years ago
issue_lock.go DBContext is just a Context (#17100) 3 years ago
issue_milestone.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_milestone_test.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_reaction.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_reaction_test.go DBContext is just a Context (#17100) 3 years ago
issue_stopwatch.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_stopwatch_test.go Move db related basic functions to models/db (#17075) 3 years ago
issue_test.go Fix issue content history problems, improve UI (#17404) 3 years ago
issue_tracked_time.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_tracked_time_test.go Move db related basic functions to models/db (#17075) 3 years ago
issue_user.go DBContext is just a Context (#17100) 3 years ago
issue_user_test.go DBContext is just a Context (#17100) 3 years ago
issue_watch.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_watch_test.go Move login related structs and functions to models/login (#17093) 3 years ago
issue_xref.go DBContext is just a Context (#17100) 3 years ago
issue_xref_test.go DBContext is just a Context (#17100) 3 years ago
lfs.go DBContext is just a Context (#17100) 3 years ago
lfs_lock.go DBContext is just a Context (#17100) 3 years ago
main_test.go Move db related basic functions to models/db (#17075) 3 years ago
migrate.go DBContext is just a Context (#17100) 3 years ago
notification.go Move login related structs and functions to models/login (#17093) 3 years ago
notification_test.go Move db related basic functions to models/db (#17075) 3 years ago
org.go [API] Add endpount to get user org permissions (#17232) 3 years ago
org_team.go Move login related structs and functions to models/login (#17093) 3 years ago
org_team_test.go Move db related basic functions to models/db (#17075) 3 years ago
org_test.go Move login related structs and functions to models/login (#17093) 3 years ago
project.go DBContext is just a Context (#17100) 3 years ago
project_board.go Kanban colored boards (#16647) 3 years ago
project_issue.go DBContext is just a Context (#17100) 3 years ago
project_test.go Move db related basic functions to models/db (#17075) 3 years ago
protected_tag.go DBContext is just a Context (#17100) 3 years ago
protected_tag_test.go Move db related basic functions to models/db (#17075) 3 years ago
pull.go Fix stange behavior of DownloadPullDiffOrPatch in incorect index (#17223) 3 years ago
pull_list.go Move login related structs and functions to models/login (#17093) 3 years ago
pull_sign.go Move twofactor to models/login (#17143) 3 years ago
pull_test.go Fix stange behavior of DownloadPullDiffOrPatch in incorect index (#17223) 3 years ago
release.go Move login related structs and functions to models/login (#17093) 3 years ago
repo.go Ensure that git daemon export ok is created for mirrors (#17243) 3 years ago
repo_activity.go DBContext is just a Context (#17100) 3 years ago
repo_archiver.go DBContext is just a Context (#17100) 3 years ago
repo_avatar.go DBContext is just a Context (#17100) 3 years ago
repo_branch.go Move newbranch to standalone package (#9627) 5 years ago
repo_collaboration.go Nicely handle missing user in collaborations (#17049) 3 years ago
repo_collaboration_test.go Move login related structs and functions to models/login (#17093) 3 years ago
repo_generate.go Move login related structs and functions to models/login (#17093) 3 years ago
repo_generate_test.go Fixed assert statements. (#16089) 3 years ago
repo_indexer.go DBContext is just a Context (#17100) 3 years ago
repo_issue.go Add EnableTimetracking option to app settings (#3719) 6 years ago
repo_language_stats.go DBContext is just a Context (#17100) 3 years ago
repo_list.go Move login related structs and functions to models/login (#17093) 3 years ago
repo_list_test.go Move login related structs and functions to models/login (#17093) 3 years ago
repo_mirror.go DBContext is just a Context (#17100) 3 years ago
repo_permission.go DBContext is just a Context (#17100) 3 years ago
repo_permission_test.go DBContext is just a Context (#17100) 3 years ago
repo_pushmirror.go DBContext is just a Context (#17100) 3 years ago
repo_pushmirror_test.go Move db related basic functions to models/db (#17075) 3 years ago
repo_redirect.go DBContext is just a Context (#17100) 3 years ago
repo_redirect_test.go DBContext is just a Context (#17100) 3 years ago
repo_sign.go Move twofactor to models/login (#17143) 3 years ago
repo_test.go DBContext is just a Context (#17100) 3 years ago
repo_transfer.go Nicely handle missing user in collaborations (#17049) 3 years ago
repo_transfer_test.go Move db related basic functions to models/db (#17075) 3 years ago
repo_unit.go Create doctor command to fix repo_units broken by dumps from 1.14.3-1.14.6 (#17136) 3 years ago
repo_watch.go Move login related structs and functions to models/login (#17093) 3 years ago
repo_watch_test.go Move login related structs and functions to models/login (#17093) 3 years ago
review.go Fix unwanted team review request deletion (#17257) 3 years ago
review_test.go Move db related basic functions to models/db (#17075) 3 years ago
ssh_key.go Move login related structs and functions to models/login (#17093) 3 years ago
ssh_key_authorized_keys.go DBContext is just a Context (#17100) 3 years ago
ssh_key_authorized_principals.go DBContext is just a Context (#17100) 3 years ago
ssh_key_deploy.go Move login related structs and functions to models/login (#17093) 3 years ago
ssh_key_fingerprint.go Move db related basic functions to models/db (#17075) 3 years ago
ssh_key_parse.go refactor: move from io/ioutil to io and os package (#17109) 3 years ago
ssh_key_principals.go Move login related structs and functions to models/login (#17093) 3 years ago
ssh_key_test.go Add support for ed25519_sk and ecdsa_sk SSH keys (#13462) 3 years ago
star.go Move login related structs and functions to models/login (#17093) 3 years ago
star_test.go Move login related structs and functions to models/login (#17093) 3 years ago
statistic.go Add metrics to get issues by repository (#17225) 3 years ago
task.go DBContext is just a Context (#17100) 3 years ago
token.go Fix problem when database ID is not incremented as expected (#17229) 3 years ago
token_test.go Move db related basic functions to models/db (#17075) 3 years ago
topic.go Move login related structs and functions to models/login (#17093) 3 years ago
topic_test.go Move login related structs and functions to models/login (#17093) 3 years ago
unit.go Kanban board (#8346) 4 years ago
update.go DBContext is just a Context (#17100) 3 years ago
upload.go DBContext is just a Context (#17100) 3 years ago
user.go Add user status filter to admin user management page (#16770) 3 years ago
user_avatar.go In many cases user avatar link should be an absolute URL with http host (#17420) 3 years ago
user_follow.go DBContext is just a Context (#17100) 3 years ago
user_follow_test.go Move db related basic functions to models/db (#17075) 3 years ago
user_heatmap.go DBContext is just a Context (#17100) 3 years ago
user_heatmap_test.go Allow mocking timeutil (#17354) 3 years ago
user_mail.go Move login related structs and functions to models/login (#17093) 3 years ago
user_mail_test.go Move login related structs and functions to models/login (#17093) 3 years ago
user_openid.go DBContext is just a Context (#17100) 3 years ago
user_openid_test.go Move db related basic functions to models/db (#17075) 3 years ago
user_redirect.go DBContext is just a Context (#17100) 3 years ago
user_redirect_test.go DBContext is just a Context (#17100) 3 years ago
user_test.go Add user status filter to admin user management page (#16770) 3 years ago
userlist.go Move twofactor to models/login (#17143) 3 years ago
userlist_test.go Move db related basic functions to models/db (#17075) 3 years ago
webhook.go Move login related structs and functions to models/login (#17093) 3 years ago
webhook_test.go Move db related basic functions to models/db (#17075) 3 years ago
wiki.go Handle and propagate errors when checking if paths are Dirs, Files or Exist (#13186) 4 years ago
wiki_test.go Move db related basic functions to models/db (#17075) 3 years ago