You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
wxiaoguang 59d060622d
Improve RSS (#24335)
Follow  #22719

### Major changes

1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`


Screenshot of changed parts:

<details>


![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png)


![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png)


![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png)

</details>


### Other thoughts

Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
1 year ago
..
actions Add runner check in repo action page (#24124) 1 year ago
branch Add RSS Feeds for branches and files (#22719) 1 year ago
cite Use data-tooltip-content for tippy tooltip (#23649) 1 year ago
diff Fix issue attachment handling (#24202) 1 year ago
editor Improve some modal action buttons (#24289) 1 year ago
find Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
graph Improve template helper functions: string/slice (#24266) 1 year ago
issue Fix template function DateTime (#24317) 1 year ago
migrate Set type="password" on all auth_token fields (#22175) 1 year ago
projects Improve some modal action buttons (#24289) 1 year ago
pulls Discolor pull request tab labels (#23950) 1 year ago
release Add tags list for repos whose release setting is disabled (#23465) 1 year ago
settings Fix template function DateTime (#24317) 1 year ago
tag Add tags list for repos whose release setting is disabled (#23465) 1 year ago
wiki Improve some modal action buttons (#24289) 1 year ago
activity.tmpl Fix template function DateTime (#24317) 1 year ago
blame.tmpl Use data-tooltip-content for tippy tooltip (#23649) 1 year ago
branch_dropdown.tmpl Improve RSS (#24335) 1 year ago
clone_buttons.tmpl Clean template/helper.go (#23922) 1 year ago
clone_script.tmpl Clean template/helper.go (#23922) 1 year ago
commit_page.tmpl Improve some modal action buttons (#24289) 1 year ago
commit_status.tmpl Use different SVG for pending and running actions (#23836) 1 year ago
commit_statuses.tmpl Fix hidden commit status on multiple checks (#22889) 1 year ago
commits.tmpl Move helpers to be prefixed with `gt-` (#22879) 1 year ago
commits_list.tmpl Add context when rendering labels or emojis (#23281) 1 year ago
commits_list_small.tmpl Use a general Eval function for expressions in templates. (#23927) 1 year ago
commits_table.tmpl Use data-tooltip-content for tippy tooltip (#23649) 1 year ago
create.tmpl Make label templates have consistent behavior and priority (#23749) 1 year ago
create_helper.tmpl Add templates to customize text when creating and migrating repositories 1 year ago
empty.tmpl Allow adding new files to an empty repo (#24164) 1 year ago
file_info.tmpl Use data-tooltip-content for tippy tooltip (#23649) 1 year ago
forks.tmpl Remove fomantic ".link" selector and styles (#23888) 1 year ago
graph.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
header.tmpl Improve External Wiki in Repo Header (#24304) 1 year ago
home.tmpl Improve RSS (#24335) 1 year ago
icon.tmpl Move helpers to be prefixed with `gt-` (#22879) 1 year ago
packages.tmpl Add main landmark to templates and adjust titles (#22670) 1 year ago
search.tmpl Use data-tooltip-content for tippy tooltip (#23649) 1 year ago
search_name.tmpl Clean template/helper.go (#23922) 1 year ago
shabox_badge.tmpl Fix shabox regression (#22924) 1 year ago
sub_menu.tmpl Add tags list for repos whose release setting is disabled (#23465) 1 year ago
sub_menu_release_tag.tmpl Add tags list for repos whose release setting is disabled (#23465) 1 year ago
unicode_escape_prompt.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
upload.tmpl Refactor `i18n` to `locale` (#20153) 2 years ago
user_cards.tmpl Fix template function DateTime (#24317) 1 year ago
view_file.tmpl Improve RSS (#24335) 1 year ago
view_list.tmpl Add wrapper to author to avoid long name ui problem (#23030) 1 year ago
watchers.tmpl Add main landmark to templates and adjust titles (#22670) 1 year ago