You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
0bc8bb3cc4
As the title. Label/assignee share the same code. * Close #22607 * Close #20727 Also: * partially fix for #21742, now the comment reaction and menu work with keyboard. * partially fix for #17705, in most cases the comment won't be lost. * partially fix for #21539 * partially fix for #20347 * partially fix for #7329 ### The `Enter` support Before, if user presses Enter, the dropdown just disappears and nothing happens or the window reloads. After, Enter can be used to select/deselect labels, and press Esc to hide the dropdown to update the labels (still no way to cancel .... maybe you can do a Cmd+R or F5 to refresh the window to discard the changes .....) This is only a quick patch, the UX is still not perfect, but it's much better than before. ### The `confirm` before reloading And more fixes for the `reload` problem, the new behaviors: * If nothing changes (just show/hide the dropdown), then the page won't be reloaded. * If there are draft comments, show a confirm dialog before reloading, to avoid losing comments. That's the best effect can be done at the moment, unless completely refactor these dropdown related code. Screenshot of the confirm dialog: <details> ![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png) </details> --------- Co-authored-by: Brecht Van Lommel <brecht@blender.org> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> |
1 year ago | |
---|---|---|
.. | ||
admin | 1 year ago | |
api/packages/pypi | 2 years ago | |
base | 1 year ago | |
code | 1 year ago | |
custom | 4 years ago | |
explore | 1 year ago | |
1 year ago | ||
org | 1 year ago | |
package | 1 year ago | |
projects | 1 year ago | |
repo | 1 year ago | |
shared | 1 year ago | |
status | 1 year ago | |
swagger | 1 year ago | |
user | 1 year ago | |
home.tmpl | 1 year ago | |
install.tmpl | 1 year ago | |
post-install.tmpl | 1 year ago |