You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/templates
wxiaoguang 0bc8bb3cc4
Make issue meta dropdown support Enter, confirm before reloading (#23014)
As the title. Label/assignee share the same code.

* Close #22607
* Close #20727

Also:

* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329

### The `Enter` support

Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.

After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)


This is only a quick patch, the UX is still not perfect, but it's much
better than before.


### The `confirm` before reloading

And more fixes for the `reload` problem, the new behaviors:

* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.

That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.

Screenshot of the confirm dialog:

<details>


![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)

</details>

---------

Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
1 year ago
..
admin Fix some more hidden problems (#23074) 1 year ago
api/packages/pypi Add Package Registry (#16510) 2 years ago
base Add accessibility to the menu on the navbar (#23059) 1 year ago
code Remove Fomantic-UI's `.hidden` CSS class for menu elements (#22895) 1 year ago
custom Add footer extra links template (#9576) 4 years ago
explore Add context cache as a request level cache (#22294) 1 year ago
mail Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
org Hide 2FA status from other members in organization members list (#22999) 1 year ago
package Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861) 1 year ago
projects Scoped labels (#22585) 1 year ago
repo Make issue meta dropdown support Enter, confirm before reloading (#23014) 1 year ago
shared Fix no user listed in org teams page (#22979) 1 year ago
status Move helpers to be prefixed with `gt-` (#22879) 1 year ago
swagger Add scopes to API to create token and display them (#22989) 1 year ago
user Add scopes to API to create token and display them (#22989) 1 year ago
home.tmpl Add main landmark to templates and adjust titles (#22670) 1 year ago
install.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
post-install.tmpl Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861) 1 year ago