You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
5d2e11eedb
`models` does far too much. In particular it handles all `UserSignin`. It shouldn't be responsible for calling LDAP, SMTP or PAM for signing in. Therefore we should move this code out of `models`. This code has to depend on `models` - therefore it belongs in `services`. There is a package in `services` called `auth` and clearly this functionality belongs in there. Plan: - [x] Change `auth.Auth` to `auth.Method` - as they represent methods of authentication. - [x] Move `models.UserSignIn` into `auth` - [x] Move `models.ExternalUserLogin` - [x] Move most of the `LoginVia*` methods to `auth` or subpackages - [x] Move Resynchronize functionality to `auth` - Involved some restructuring of `models/ssh_key.go` to reduce the size of this massive file and simplify its files. - [x] Move the rest of the LDAP functionality in to the ldap subpackage - [x] Re-factor the login sources to express an interfaces `auth.Source`? - I've done this through some smaller interfaces Authenticator and Synchronizable - which would allow us to extend things in future - [x] Now LDAP is out of models - need to think about modules/auth/ldap and I think all of that functionality might just be moveable - [x] Similarly a lot Oauth2 functionality need not be in models too and should be moved to services/auth/source/oauth2 - [x] modules/auth/oauth2/oauth2.go uses xorm... This is naughty - probably need to move this into models. - [x] models/oauth2.go - mostly should be in modules/auth/oauth2 or services/auth/source/oauth2 - [x] More simplifications of login_source.go may need to be done - Allow wiring in of notify registration - *this can now easily be done - but I think we should do it in another PR* - see #16178 - More refactors...? - OpenID should probably become an auth Method but I think that can be left for another PR - Methods should also probably be cleaned up - again another PR I think. - SSPI still needs more refactors.* Rename auth.Auth auth.Method * Restructure ssh_key.go - move functions from models/user.go that relate to ssh_key to ssh_key - split ssh_key.go to try create clearer function domains for allow for future refactors here. Signed-off-by: Andrew Thornton <art27@cantab.net> |
3 years ago | |
|---|---|---|
| .. | ||
| analyze | 3 years ago | |
| auth | 3 years ago | |
| avatar | 3 years ago | |
| base | 3 years ago | |
| cache | 3 years ago | |
| charset | 3 years ago | |
| context | 3 years ago | |
| convert | 3 years ago | |
| cron | 3 years ago | |
| csv | 3 years ago | |
| doctor | 3 years ago | |
| emoji | 3 years ago | |
| eventsource | 3 years ago | |
| generate | 3 years ago | |
| git | 3 years ago | |
| gitgraph | 3 years ago | |
| graceful | 3 years ago | |
| hcaptcha | 4 years ago | |
| highlight | 3 years ago | |
| httpcache | 3 years ago | |
| httplib | 3 years ago | |
| indexer | 3 years ago | |
| lfs | 3 years ago | |
| log | 3 years ago | |
| markup | 3 years ago | |
| matchlist | 4 years ago | |
| metrics | 6 years ago | |
| migrations | 3 years ago | |
| nosql | 3 years ago | |
| notification | 3 years ago | |
| options | 4 years ago | |
| password | 3 years ago | |
| pprof | 5 years ago | |
| private | 3 years ago | |
| process | 3 years ago | |
| public | 3 years ago | |
| queue | 3 years ago | |
| recaptcha | 3 years ago | |
| references | 3 years ago | |
| repofiles | 3 years ago | |
| repository | 3 years ago | |
| secret | 3 years ago | |
| session | 3 years ago | |
| setting | 3 years ago | |
| ssh | 3 years ago | |
| storage | 3 years ago | |
| structs | 3 years ago | |
| svg | 4 years ago | |
| sync | 5 years ago | |
| task | 3 years ago | |
| templates | 3 years ago | |
| test | 3 years ago | |
| timeutil | 3 years ago | |
| translation | 3 years ago | |
| typesniffer | 3 years ago | |
| upload | 4 years ago | |
| uri | 4 years ago | |
| user | 4 years ago | |
| util | 3 years ago | |
| validation | 3 years ago | |
| web | 3 years ago | |