You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/modules/repository
Jason Song 1e76a824bc
Refactor and enhance issue indexer to support both searching, filtering and paging (#26012)
Fix #24662.

Replace #24822 and #25708 (although it has been merged)


## Background

In the past, Gitea supported issue searching with a keyword and
conditions in a less efficient way. It worked by searching for issues
with the keyword and obtaining limited IDs (as it is heavy to get all)
on the indexer (bleve/elasticsearch/meilisearch), and then querying with
conditions on the database to find a subset of the found IDs. This is
why the results could be incomplete.

To solve this issue, we need to store all fields that could be used as
conditions in the indexer and support both keyword and additional
conditions when searching with the indexer.

## Major changes

- Redefine `IndexerData` to include all fields that could be used as
filter conditions.
- Refactor `Search(ctx context.Context, kw string, repoIDs []int64,
limit, start int, state string)` to `Search(ctx context.Context, options
*SearchOptions)`, so it supports more conditions now.
- Change the data type stored in `issueIndexerQueue`. Use
`IndexerMetadata` instead of `IndexerData` in case the data has been
updated while it is in the queue. This also reduces the storage size of
the queue.
- Enhance searching with Bleve/Elasticsearch/Meilisearch, make them
fully support `SearchOptions`. Also, update the data versions.
- Keep most logic of database indexer, but remove
`issues.SearchIssueIDsByKeyword` in `models` to avoid confusion where is
the entry point to search issues.
- Start a Meilisearch instance to test it in unit tests.
- Add unit tests with almost full coverage to test
Bleve/Elasticsearch/Meilisearch indexer.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
11 months ago
..
branch.go Fix branch commit message too long problem (#25588) 1 year ago
collaborator.go Always reuse transaction (#22362) 2 years ago
collaborator_test.go Rename `repo.GetOwner` to `repo.LoadOwner` (#22967) 1 year ago
commits.go Add context cache as a request level cache (#22294) 1 year ago
commits_test.go Improve avatar uploading / resizing / compressing, remove Fomantic card module (#24653) 1 year ago
create.go Refactor and enhance issue indexer to support both searching, filtering and paging (#26012) 11 months ago
create_test.go Map OIDC groups to Orgs/Teams (#21441) 1 year ago
delete.go Allow repo admins too to delete the repo (#23940) 1 year ago
env.go Implement actions (#21937) 1 year ago
fork.go Implement FSFE REUSE for golang files (#21840) 2 years ago
generate.go Support copy protected branch from template repository (#25889) 12 months ago
generate_test.go Substitute variables in path names of template repos too (#25294) 1 year ago
hooks.go Implement FSFE REUSE for golang files (#21840) 2 years ago
init.go Sync branches into databases (#22743) 1 year ago
init_test.go Make label templates have consistent behavior and priority (#23749) 1 year ago
license.go Replace placeholders in licenses (#24354) 1 year ago
license_test.go Replace placeholders in licenses (#24354) 1 year ago
main_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
push.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 1 year ago
repo.go Sync branches into databases (#22743) 1 year ago
temp.go Implement FSFE REUSE for golang files (#21840) 2 years ago