You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/modules
Jason Song 174213530d
Fix `Permission` in API returned repository struct (#25388)
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.
1 year ago
..
actions Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 1 year ago
activitypub Add Chef package registry (#22554) 2 years ago
analyze Implement FSFE REUSE for golang files (#21840) 2 years ago
assetfs Use a general approach to access custom/static/builtin assets (#24022) 1 year ago
auth Use a general approach to access custom/static/builtin assets (#24022) 1 year ago
avatar Improve avatar uploading / resizing / compressing, remove Fomantic card module (#24653) 1 year ago
base Use a general Eval function for expressions in templates. (#23927) 1 year ago
cache Update redis library to support redis v7 (#24114) 1 year ago
charset Update go tool dependencies, restructure lint targets (#24239) 1 year ago
container Implement FSFE REUSE for golang files (#21840) 2 years ago
context Batch delete issue and improve tippy opts (#25253) 1 year ago
csv Refactor locale number (#24134) 1 year ago
doctor Refactor path & config system (#25330) 1 year ago
emoji Fix unstable emoji sort (#22346) 2 years ago
eventsource Move `convert` package to services (#22264) 2 years ago
generate Implement FSFE REUSE for golang files (#21840) 2 years ago
git Fix index generation parallelly failure (#25235) 1 year ago
gitgraph Add context cache as a request level cache (#22294) 1 year ago
graceful Improve queue and logger context (#24924) 1 year ago
hcaptcha Consume hcaptcha and pwn deps (#22610) 2 years ago
highlight test_env: hardcode major go version in use (#23464) 1 year ago
hostmatcher Implement FSFE REUSE for golang files (#21840) 2 years ago
html Implement FSFE REUSE for golang files (#21840) 2 years ago
httpcache Use standard HTTP library to serve files (#24693) 1 year ago
httplib Use fetch to send requests to create issues/comments (#25258) 1 year ago
indexer Improve queue and logger context (#24924) 1 year ago
issue/template Allow issue templates to not render title (#22589) 2 years ago
json Update gitea-vet to check FSFE REUSE (#22004) 2 years ago
label Make label templates have consistent behavior and priority (#23749) 1 year ago
lfs Rewrite logger system (#24726) 1 year ago
log Improve logger Pause handling (#24946) 1 year ago
markup Refactor path & config system (#25330) 1 year ago
mcaptcha Implement FSFE REUSE for golang files (#21840) 2 years ago
metrics Use a separate admin page to show global stats, remove `actions` stat (#25062) 1 year ago
migration Scoped labels (#22585) 1 year ago
mirror Improve queue and logger context (#24924) 1 year ago
nosql Update redis library to support redis v7 (#24114) 1 year ago
notification Rename NotifyPullReviewRequest to NotifyPullRequestReviewRequest (#24988) 1 year ago
options Use a general approach to access custom/static/builtin assets (#24022) 1 year ago
packages Add CRAN package registry (#22331) 1 year ago
paginator Use more specific test methods (#24265) 1 year ago
pprof Implement FSFE REUSE for golang files (#21840) 2 years ago
private Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 1 year ago
process Do not output "Trace" level logs from process manager by default (#24952) 1 year ago
proxy Use proxy for pull mirror (#22771) 2 years ago
proxyprotocol Implement FSFE REUSE for golang files (#21840) 2 years ago
public Use standard HTTP library to serve files (#24693) 1 year ago
queue Help to recover from corrupted levelqueue (#24912) 1 year ago
recaptcha Implement FSFE REUSE for golang files (#21840) 2 years ago
references Use correct captured group range when parsing cross-reference (#22672) 2 years ago
regexplru Implement FSFE REUSE for golang files (#21840) 2 years ago
repository Move some regexp out of functions (#25430) 1 year ago
secret Improve decryption failure message (#24573) 1 year ago
session Update redis library to support redis v7 (#24114) 1 year ago
setting Remove "CHARSET" config option for MySQL, always use "utf8mb4" (#25413) 1 year ago
sitemap Fix sitemap (#22272) 2 years ago
ssh Refactor path & config system (#25330) 1 year ago
storage Fix all possible setting error related storages and added some tests (#23911) 1 year ago
structs Fix `Permission` in API returned repository struct (#25388) 1 year ago
svg Use inline SVG for built-in OAuth providers (#25171) 1 year ago
sync Implement FSFE REUSE for golang files (#21840) 2 years ago
system Implement FSFE REUSE for golang files (#21840) 2 years ago
templates Fix missing commit message body when the message has leading newlines (#25418) 1 year ago
test Refactor web package and context package (#25298) 1 year ago
testlogger Refactor path & config system (#25330) 1 year ago
timeutil Fix incorrect webhook time and use relative-time to display it (#24477) 1 year ago
translation Refactor INI package (first step) (#25024) 1 year ago
turnstile Add new captcha: cloudflare turnstile (#22369) 2 years ago
typesniffer Do not recognize text files as audio (#23355) 1 year ago
updatechecker Implement FSFE REUSE for golang files (#21840) 2 years ago
upload Implement FSFE REUSE for golang files (#21840) 2 years ago
uri Implement FSFE REUSE for golang files (#21840) 2 years ago
user Implement FSFE REUSE for golang files (#21840) 2 years ago
util Move some regexp out of functions (#25430) 1 year ago
validation Map OIDC groups to Orgs/Teams (#21441) 2 years ago
web Refactor web package and context package (#25298) 1 year ago
webhook New webhook trigger for receiving Pull Request review requests (#24481) 1 year ago