You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/routers/private
CaiCandong 815d267c80
Fix verifyCommits error when push a new branch (#26664)
> ### Description
> If a new branch is pushed, and the repository has a rule that would
require signed commits for the new branch, the commit is rejected with a
500 error regardless of whether it's signed.
> 
> When pushing a new branch, the "old" commit is the empty ID
(0000000000000000000000000000000000000000). verifyCommits has no
provision for this and passes an invalid commit range to git rev-list.
Prior to 1.19 this wasn't an issue because only pre-existing individual
branches could be protected.
> 
> I was able to reproduce with
[try.gitea.io/CraigTest/test](https://try.gitea.io/CraigTest/test),
which is set up with a blanket rule to require commits on all branches.


Fix #25565
Very thanks to @Craig-Holmquist-NTI for reporting the bug and suggesting
an valid solution!

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
10 months ago
..
tests/repos Fix verifyCommits error when push a new branch (#26664) 10 months ago
actions.go parseScope with owner/repo always sets owner to zero (#25987) 12 months ago
default_branch.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 1 year ago
hook_post_receive.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 1 year ago
hook_pre_receive.go Add context parameter to some database functions (#26055) 12 months ago
hook_proc_receive.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 1 year ago
hook_verification.go Fix verifyCommits error when push a new branch (#26664) 10 months ago
hook_verification_test.go Fix verifyCommits error when push a new branch (#26664) 10 months ago
internal.go Add gitea manager reload-templates command (#24843) 1 year ago
internal_repo.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 1 year ago
key.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 1 year ago
mail.go Prevent multiple `To` recipients (#22566) 1 year ago
main_test.go Fix verifyCommits error when push a new branch (#26664) 10 months ago
manager.go Fix logger refactoring regression: manager logging add (#24847) 1 year ago
manager_process.go Replace `interface{}` with `any` (#25686) 1 year ago
manager_unix.go Implement FSFE REUSE for golang files (#21840) 2 years ago
manager_windows.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 1 year ago
restore_repo.go Fix regression: access log template, gitea manager cli command (#24838) 1 year ago
serv.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 1 year ago
ssh_log.go Refactor the setting to make unit test easier (#22405) 1 year ago