You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
44f2c27d28
closed #17378 Both errors from #17378 were caused by #15175. Problem 1 (error with added file): `ToUTF8WithFallbackReader` creates a `MultiReader` from a `byte[2048]` and the remaining reader. `CreateReaderAndGuessDelimiter` tries to read 10000 bytes from this reader but only gets 2048 because that's the first reader in the `MultiReader`. Then the `if size < 1e4` thinks the input is at EOF and just returns that. Problem 2 (error with changed file): The blob reader gets defer closed. That was fine because the old version reads the whole file into memory. Now with the streaming version the close needs to defer after the method. |
3 years ago | |
|---|---|---|
| .. | ||
| activity.go | 3 years ago | |
| attachment.go | 3 years ago | |
| blame.go | 3 years ago | |
| branch.go | 3 years ago | |
| commit.go | 3 years ago | |
| compare.go | 3 years ago | |
| download.go | 3 years ago | |
| editor.go | 3 years ago | |
| editor_test.go | 3 years ago | |
| http.go | 3 years ago | |
| http_test.go | 3 years ago | |
| issue.go | 3 years ago | |
| issue_content_history.go | 3 years ago | |
| issue_dependency.go | 3 years ago | |
| issue_label.go | 3 years ago | |
| issue_label_test.go | 3 years ago | |
| issue_lock.go | 3 years ago | |
| issue_stopwatch.go | 3 years ago | |
| issue_test.go | 3 years ago | |
| issue_timetrack.go | 3 years ago | |
| issue_watch.go | 3 years ago | |
| lfs.go | 3 years ago | |
| main_test.go | 3 years ago | |
| middlewares.go | 3 years ago | |
| migrate.go | 3 years ago | |
| milestone.go | 3 years ago | |
| projects.go | 3 years ago | |
| projects_test.go | 3 years ago | |
| pull.go | 3 years ago | |
| pull_review.go | 3 years ago | |
| release.go | 3 years ago | |
| release_test.go | 3 years ago | |
| repo.go | 3 years ago | |
| search.go | 3 years ago | |
| setting.go | 3 years ago | |
| setting_protected_branch.go | 3 years ago | |
| settings_test.go | 3 years ago | |
| tag.go | 3 years ago | |
| topic.go | 3 years ago | |
| view.go | 3 years ago | |
| webhook.go | 3 years ago | |
| wiki.go | 3 years ago | |
| wiki_test.go | 3 years ago | |