You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath dd12384f22
Fix --port setting (#13288)
* Fix --port setting

Unfortunately there was an error in #13195 which set the --port
option before the settings were read. This PR fixes this by
moving applying this option to after the the settings are read

However, on looking further into this code I believe that the setPort
code was slightly odd.

Firstly, it may make sense to run the install page on a different
temporary port to the full system and this should be possible with
a --install-port option.

Secondy, if the --port option is provided we should apply it to both
otherwise there will be unusual behaviour on graceful restart

Thirdly, the documentation for --port says that the setting is
temporary - it should therefore not save its result to the configuration

(This however, does mean that authorized_keys and internal links may
not be correct. - I think we need to discuss this option further.)

Fix #13277

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update cmd/web.go

* Apply suggestions from code review

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
4 years ago
..
backup-and-restore.en-us.md Add charset handling to backup/restore doc (#11062) 4 years ago
backup-and-restore.zh-cn.md Add charset handling to backup/restore doc (#11062) 4 years ago
backup-and-restore.zh-tw.md Import docs into main repository (#2874) 7 years ago
command-line.en-us.md Fix --port setting (#13288) 4 years ago
email-setup.en-us.md Add warning to mailer documentation about authentication (#11563) 4 years ago
fail2ban-setup.en-us.md Fix hugo shortcode typo in faq (#12987) 4 years ago
git-lfs-support.md Doc added instructions for Git LFS support (#8391) 5 years ago
https-support.md Clarification on the use of certificate chains (#12986) 4 years ago
issue-pull-request-templates.en-us.md Issue templates directory (#11450) 4 years ago
issue-pull-request-templates.zh-cn.md ZH-CN translation of Usage part (#5086) 6 years ago
linked-references.en-us.md Add spent time to referenced issue in commit message (#12220) 4 years ago
pull-request.en-us.md Copyedit docs (#6275) 5 years ago
pull-request.zh-cn.md ZH-CN translation of Usage part (#5086) 6 years ago
push-options.en-us.md Initial support for push options (#12169) 4 years ago
reverse-proxies.en-us.md Use correct make target for building static assets (#12247) 4 years ago
reverse-proxies.zh-cn.md Fix regression in reverse proxy documentation (#7634) 5 years ago
template-repositories.md More expansions in template repositories (#10021) 5 years ago