You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
9607750b5e
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x",
[]byte)`, we should use it as much as possible.
I'm not an extreme fan of performance, so I think there are some
exceptions:
- `fmt.Sprintf("%x", func(...)[N]byte())`
- We can't slice the function return value directly, and it's not worth
adding lines.
```diff
func A()[20]byte { ... }
- a := fmt.Sprintf("%x", A())
- a := hex.EncodeToString(A()[:]) // invalid
+ tmp := A()
+ a := hex.EncodeToString(tmp[:])
```
- `fmt.Sprintf("%X", []byte)`
- `strings.ToUpper(hex.EncodeToString(bytes))` has even worse
performance.
|
2 years ago | |
|---|---|---|
| .. | ||
| agit | 2 years ago | |
| asymkey | 2 years ago | |
| attachment | 2 years ago | |
| auth | 2 years ago | |
| automerge | 2 years ago | |
| comments | 2 years ago | |
| context | 2 years ago | |
| cron | 2 years ago | |
| externalaccount | 2 years ago | |
| forms | 2 years ago | |
| gitdiff | 2 years ago | |
| issue | 2 years ago | |
| lfs | 2 years ago | |
| mailer | 2 years ago | |
| markup | 2 years ago | |
| migrations | 2 years ago | |
| mirror | 2 years ago | |
| org | 2 years ago | |
| packages | 2 years ago | |
| pull | 2 years ago | |
| release | 2 years ago | |
| repository | 2 years ago | |
| task | 2 years ago | |
| user | 2 years ago | |
| webhook | 2 years ago | |
| wiki | 2 years ago | |