You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath b091c994b5
Comments on review should have the same sha (#13448)
* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Fix broken migration

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix mssql

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix mssql

Signed-off-by: Andrew Thornton <art27@cantab.net>

* move session within the batch

Signed-off-by: Andrew Thornton <art27@cantab.net>

* regen the sqlcmd each time round the loop

Signed-off-by: Andrew Thornton <art27@cantab.net>

* as per @lunny

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
4 years ago
..
check.go [Enhancement] Allow admin to merge pr with protected file changes (#12078) 4 years ago
check_test.go Only check for conflicts/merging if the PR has not been merged in the interim (#10132) 4 years ago
commit_status.go Fix bug on pull view when required status check no ci result (#10648) 4 years ago
lfs.go Add basic repository lfs management (#7199) 5 years ago
main_test.go Move some pull request functions from models to services (#9266) 5 years ago
merge.go go-version constraints ignore pre-releases (#13234) 4 years ago
patch.go [Enhancement] Allow admin to merge pr with protected file changes (#12078) 4 years ago
pull.go [Enhancement] Allow admin to merge pr with protected file changes (#12078) 4 years ago
pull_test.go Move PushToBaseRepo from models to services/pull (#9352) 5 years ago
review.go Comments on review should have the same sha (#13448) 4 years ago
temp_repo.go Handle more pathological branch and tag names (#11843) 4 years ago
update.go Check Push permissions on IsUserAllowedToUpdate (#11448) 4 years ago