You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
sillyguodong
2f49b55c19
Fix cannot reopen after pushing commits to a closed PR (#23189)
Close: #22784
1. On GH, we can reopen a PR which was closed before after pushing
commits. After reopening PR, we can see the commits that were pushed
after closing PR in the time line. So the case of
[issue](https://github.com/go-gitea/gitea/issues/22784) is a bug which
needs to be fixed.
2. After closing a PR and pushing commits, `headBranchSha` is not equal
to `sha`(which is the last commit ID string of reference). If the
judgement exists, the button of reopen will not display. So, skip the
judgement if the status of PR is closed.
3. Even if PR is already close, we should still insert comment record
into DB when we push commits.
So we should still call function `CreatePushPullComment()`.
067b0c2664/services/pull/pull.go (L260-L282)
So, I add a switch(`includeClosed`) to the
`GetUnmergedPullRequestsByHeadInfo` func to control whether the status
of PR must be open. In this case, by setting `includeClosed` to `true`,
we can query the closed PR.
4. In the loop of comments, I use the`latestCloseCommentID` variable to
record the last occurrence of the close comment.
In the go template, if the status of PR is closed, the comments whose
type is `CommentTypePullRequestPush(29)` after `latestCloseCommentID`
won't be rendered.
e.g.
1). The initial status of the PR is opened.
2). Then I click the button of `Close`. PR is closed now.
3). I try to push a commit to this PR, even though its current status is
closed.
But in comments list, this commit do not display.This is as expected ：）
4). Click the `Reopen` button, the commit which is pushed after closing
PR display now.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
|
1 year ago |
| .. |
|
admin
|
Use context parameter in services/repository (#23186)
|
1 year ago |
|
auth
|
Provide the ability to set password hash algorithm parameters (#22942)
|
1 year ago |
|
events
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
explore
|
Remove useless comment in #23114 (#23173)
|
1 year ago |
|
feed
|
Add pagination for dashboard and user activity feeds (#22937)
|
1 year ago |
|
healthcheck
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
misc
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
org
|
Add loading yaml label template files (#22976)
|
1 year ago |
|
repo
|
Fix cannot reopen after pushing commits to a closed PR (#23189)
|
1 year ago |
|
shared
|
Add Cargo package registry (#21888)
|
1 year ago |
|
user
|
Use context parameter in services/repository (#23186)
|
1 year ago |
|
auth.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
auth_windows.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
base.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
goget.go
|
refactor some functions to support ctx as first parameter (#21878)
|
2 years ago |
|
home.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
metrics.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
nodeinfo.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
swagger_json.go
|
Implement FSFE REUSE for golang files (#21840)
|
2 years ago |
|
web.go
|
Require approval to run actions for fork pull request (#22803)
|
1 year ago |
|
webfinger.go
|
Add context cache as a request level cache (#22294)
|
1 year ago |
