You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
admin Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
auth Record OAuth client type at registration (#21316) 2 years ago
dev Make better use of i18n (#20096) 2 years ago
events Improve Stopwatch behavior (#18930) 2 years ago
explore Remove deleted repos from searchresult (#21512) 2 years ago
feed Show private data in feeds (#21369) 2 years ago
healthcheck Update go-chi/cache to utilize Ping() (#19719) 2 years ago
misc Fix panic in team repos API (#19431) 2 years ago
org move invite by mail to services package (#21513) 2 years ago
repo adapt README_{Country}.md stype name in localizedExtensions (#21486) 2 years ago
user Record OAuth client type at registration (#21316) 2 years ago
auth.go Remove legacy `+build:` constraint (#19582) 2 years ago
auth_windows.go Let web and API routes have different auth methods group (#19168) 2 years ago
base.go Share HTML template renderers and create a watcher framework (#20218) 2 years ago
goget.go Refactor legacy `unknwon/com` package, improve golangci lint (#19284) 2 years ago
home.go Add sitemap support (#18407) 2 years ago
metrics.go Update HTTP status codes to modern codes (#18063) 2 years ago
nodeinfo.go Add nodeinfo endpoint for federation purposes (#16953) 3 years ago
swagger_json.go Refactor routers directory (#15800) 3 years ago
web.go Added check for disabled Packages (#21540) 2 years ago
webfinger.go Fix various typos (#20338) 2 years ago