You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/services
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
agit Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
asymkey Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
attachment Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
auth SessionUser protection against nil pointer dereference (#21358) 2 years ago
automerge Add more linters to improve code readability (#19989) 2 years ago
comments Move issues related files into models/issues (#19931) 2 years ago
context Move almost all functions' parameter db.Engine to context.Context (#19748) 2 years ago
cron Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
externalaccount Refactor auth package (#17962) 3 years ago
forms Record OAuth client type at registration (#21316) 2 years ago
gitdiff Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
issue Update milestone counters when issue is deleted (#21459) 2 years ago
lfs Prevent Authorization header for presigned LFS urls (#21531) 2 years ago
mailer Add team member invite by email (#20307) 2 years ago
markup Link mentioned user in markdown only if they are visible to viewer (#21554) 2 years ago
migrations Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
mirror Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
org move invite by mail to services package (#21513) 2 years ago
packages Replace `ServeStream` with `ServeContent` (#20903) 2 years ago
pull Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
release Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
repository Refactor git command arguments and make all arguments to be safe to be used (#21535) 2 years ago
task Move some files into models' sub packages (#20262) 2 years ago
user Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
webhook Decouple HookTask from Repository (#17940) 2 years ago
wiki Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago