You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
SteveTheEngineer 1e2c2edab6
Catch the error before the response is processed by goth. (#20000)
The code introduced by #18185 gets the error from response after it was processed by goth.

That is incorrect, as goth (and golang.org/x/oauth) doesn't really care about the error, and it sends a token request with an empty authorization code to the server anyway, which always results in a `oauth2: cannot fetch token: 400 Bad Request` error from goth.
It means that unless the "state" parameter is omitted from the error response (which is required to be present, according to [RFC 6749, Section 4.1.2.1](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1)) or the page is reloaded (makes the session invalid), a 500 Internal Server Error page will be displayed.
This fixes it by handling the error before the request is passed to goth.
2 years ago
..
admin Add more linters to improve code readability (#19989) 2 years ago
auth Catch the error before the response is processed by goth. (#20000) 2 years ago
dev Move user related model into models/user (#17781) 3 years ago
events Improve Stopwatch behavior (#18930) 2 years ago
explore In code search, get code unit accessible repos in one (main) query (#19764) 2 years ago
feed Add more linters to improve code readability (#19989) 2 years ago
healthcheck Update go-chi/cache to utilize Ping() (#19719) 2 years ago
misc Fix panic in team repos API (#19431) 2 years ago
org Move issues related files into models/issues (#19931) 2 years ago
repo Add more linters to improve code readability (#19989) 2 years ago
user Add more linters to improve code readability (#19989) 2 years ago
auth.go Remove legacy `+build:` constraint (#19582) 2 years ago
auth_windows.go Let web and API routes have different auth methods group (#19168) 2 years ago
base.go Update base.go (#19739) 2 years ago
goget.go Refactor legacy `unknwon/com` package, improve golangci lint (#19284) 2 years ago
home.go Renamed ctx.User to ctx.Doer. (#19161) 2 years ago
metrics.go Update HTTP status codes to modern codes (#18063) 2 years ago
nodeinfo.go Add nodeinfo endpoint for federation purposes (#16953) 3 years ago
swagger_json.go Refactor routers directory (#15800) 3 years ago
web.go Add more linters to improve code readability (#19989) 2 years ago
webfinger.go User keypairs and HTTP signatures for ActivityPub federation using go-ap (#19133) 2 years ago