You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Lunny Xiao 62e6c9bc6c
Add a storage layer for attachments (#11387)
* Add a storage layer for attachments

* Fix some bug

* fix test

* Fix copyright head and lint

* Fix bug

* Add setting for minio and flags for migrate-storage

* Add documents

* fix lint

* Add test for minio store type on attachments

* fix test

* fix test

* Apply suggestions from code review

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Add warning when storage migrated successfully

* Fix drone

* fix test

* rebase

* Fix test

* display the error on console

* Move minio test to amd64 since minio docker don't support arm64

* refactor the codes

* add trace

* Fix test

* remove log on xorm

* Fi download bug

* Add a storage layer for attachments

* Add setting for minio and flags for migrate-storage

* fix lint

* Add test for minio store type on attachments

* Apply suggestions from code review

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Fix drone

* fix test

* Fix test

* display the error on console

* Move minio test to amd64 since minio docker don't support arm64

* refactor the codes

* add trace

* Fix test

* Add URL function to serve attachments directly from S3/Minio

* Add ability to enable/disable redirection in attachment configuration

* Fix typo

* Add a storage layer for attachments

* Add setting for minio and flags for migrate-storage

* fix lint

* Add test for minio store type on attachments

* Apply suggestions from code review

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Fix drone

* fix test

* Fix test

* display the error on console

* Move minio test to amd64 since minio docker don't support arm64

* don't change unrelated files

* Fix lint

* Fix build

* update go.mod and go.sum

* Use github.com/minio/minio-go/v6

* Remove unused function

* Upgrade minio to v7 and some other improvements

* fix lint

* Fix go mod

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: Tyler <tystuyfzand@gmail.com>
4 years ago
..
.gitignore Add a storage layer for attachments (#11387) 4 years ago
.travis.yml Add a storage layer for attachments (#11387) 4 years ago
Gopkg.lock Add a storage layer for attachments (#11387) 4 years ago
Gopkg.toml Add a storage layer for attachments (#11387) 4 years ago
LICENSE Add a storage layer for attachments (#11387) 4 years ago
README.md Add a storage layer for attachments (#11387) 4 years ago
go_above_17.go Add a storage layer for attachments (#11387) 4 years ago
go_above_19.go Add a storage layer for attachments (#11387) 4 years ago
go_below_17.go Add a storage layer for attachments (#11387) 4 years ago
go_below_19.go Add a storage layer for attachments (#11387) 4 years ago
reflect2.go Add a storage layer for attachments (#11387) 4 years ago
reflect2_amd64.s Add a storage layer for attachments (#11387) 4 years ago
reflect2_kind.go Add a storage layer for attachments (#11387) 4 years ago
relfect2_386.s Add a storage layer for attachments (#11387) 4 years ago
relfect2_amd64p32.s Add a storage layer for attachments (#11387) 4 years ago
relfect2_arm.s Add a storage layer for attachments (#11387) 4 years ago
relfect2_arm64.s Add a storage layer for attachments (#11387) 4 years ago
relfect2_mips64x.s Add a storage layer for attachments (#11387) 4 years ago
relfect2_mipsx.s Add a storage layer for attachments (#11387) 4 years ago
relfect2_ppc64x.s Add a storage layer for attachments (#11387) 4 years ago
relfect2_s390x.s Add a storage layer for attachments (#11387) 4 years ago
safe_field.go Add a storage layer for attachments (#11387) 4 years ago
safe_map.go Add a storage layer for attachments (#11387) 4 years ago
safe_slice.go Add a storage layer for attachments (#11387) 4 years ago
safe_struct.go Add a storage layer for attachments (#11387) 4 years ago
safe_type.go Add a storage layer for attachments (#11387) 4 years ago
test.sh Add a storage layer for attachments (#11387) 4 years ago
type_map.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_array.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_eface.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_field.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_iface.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_link.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_map.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_ptr.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_slice.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_struct.go Add a storage layer for attachments (#11387) 4 years ago
unsafe_type.go Add a storage layer for attachments (#11387) 4 years ago

README.md

reflect2

Sourcegraph GoDoc Build Status codecov rcard License

reflect api that avoids runtime reflect.Value cost

  • reflect get/set interface{}, with type checking
  • reflect get/set unsafe.Pointer, without type checking
  • reflect2.TypeByName works like Class.forName found in java

json-iterator use this package to save runtime dispatching cost. This package is designed for low level libraries to optimize reflection performance. General application should still use reflect standard library.

reflect2.TypeByName

// given package is github.com/your/awesome-package
type MyStruct struct {
	// ...
}

// will return the type
reflect2.TypeByName("awesome-package.MyStruct")
// however, if the type has not been used
// it will be eliminated by compiler, so we can not get it in runtime

reflect2 get/set interface

valType := reflect2.TypeOf(1)
i := 1
j := 10
valType.Set(&i, &j)
// i will be 10

to get set type, always use its pointer *type

reflect2 get/set unsafe.Pointer

valType := reflect2.TypeOf(1)
i := 1
j := 10
valType.UnsafeSet(unsafe.Pointer(&i), unsafe.Pointer(&j))
// i will be 10

to get set type, always use its pointer *type

benchmark

Benchmark is not necessary for this package. It does nothing actually. As it is just a thin wrapper to make go runtime public. Both reflect2 and reflect call same function provided by runtime package exposed by go language.

unsafe safety

Instead of casting []byte to sliceHeader in your application using unsafe. We can use reflect2 instead. This way, if sliceHeader changes in the future, only reflect2 need to be upgraded.

reflect2 tries its best to keep the implementation same as reflect (by testing).