meissa
/
forgejo
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '891391689a'
${ noResults }
forgejo/models/repo
History
Jason Song 82728a7cec
Do not overwrite empty DefaultBranch (#22708) 
Fix #21994. 
And fix #19470.

While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".


19d5b2f922/modules/repository/generate.go (L241-L253)

Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:


19d5b2f922/models/repo/repo.go (L228-L233)

I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)

I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
 		1 year ago
..
archiver.go Implement FSFE REUSE for golang files (#21840) 2 years ago
attachment.go Implement FSFE REUSE for golang files (#21840) 2 years ago
attachment_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
avatar.go Implement FSFE REUSE for golang files (#21840) 2 years ago
collaboration.go Always reuse transaction (#22362) 1 year ago
collaboration_test.go Rename almost all Ctx functions (#22071) 2 years ago
fork.go Implement FSFE REUSE for golang files (#21840) 2 years ago
fork_test.go refactor some functions to support ctx as first parameter (#21878) 2 years ago
git.go Implement FSFE REUSE for golang files (#21840) 2 years ago
issue.go Rename almost all Ctx functions (#22071) 2 years ago
language_stats.go Round language stats percentage using largest remainder (#22026) 2 years ago
main_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
mirror.go Use ErrInvalidArgument in packages (#22268) 2 years ago
pushmirror.go Use ErrInvalidArgument in packages (#22268) 2 years ago
pushmirror_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
redirect.go Implement FSFE REUSE for golang files (#21840) 2 years ago
redirect_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
release.go Use ErrInvalidArgument in packages (#22268) 2 years ago
repo.go Do not overwrite empty DefaultBranch (#22708) 1 year ago
repo_indexer.go Implement FSFE REUSE for golang files (#21840) 2 years ago
repo_list.go Fix Operator does not exist bug on explore page with ONLY_SHOW_RELEVANT_REPOS (#22454) 1 year ago
repo_list_test.go Add a simple test for external renderer (#20033) 2 years ago
repo_test.go refactor some functions to support ctx as first parameter (#21878) 2 years ago
repo_unit.go Implement actions (#21937) 1 year ago
star.go Implement FSFE REUSE for golang files (#21840) 2 years ago
star_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
topic.go Implement FSFE REUSE for golang files (#21840) 2 years ago
topic_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
update.go Fix error when calculate the repository size (#22392) 1 year ago
upload.go Implement FSFE REUSE for golang files (#21840) 2 years ago
user_repo.go Implement FSFE REUSE for golang files (#21840) 2 years ago
user_repo_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
watch.go Implement FSFE REUSE for golang files (#21840) 2 years ago
watch_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
wiki.go Implement FSFE REUSE for golang files (#21840) 2 years ago
wiki_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago