You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Eng Zer Jun 8b0aaa5f86
test: use `T.TempDir` to create temporary test directory (#21043)
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2 years ago
..
activity.go Move some files into models' sub packages (#20262) 2 years ago
attachment.go Move some repository related code into sub package (#19711) 2 years ago
blame.go Switch Unicode Escaping to a VSCode-like system (#19990) 2 years ago
branch.go Add more linters to improve code readability (#19989) 2 years ago
cherry_pick.go Remove `RequireHighlightJS` field, update plantuml example. (#19615) 2 years ago
commit.go Move some code into models/git (#19879) 2 years ago
compare.go Support Issue forms and PR forms (#20987) 2 years ago
download.go Slightly simplify LastCommitCache (#20444) 2 years ago
editor.go Move some files into models' sub packages (#20262) 2 years ago
editor_test.go Add more linters to improve code readability (#19989) 2 years ago
find.go Feature: Find files in repo (#15028) 2 years ago
http.go Use request timeout for git service rpc (#20689) 2 years ago
http_test.go Fix http path bug (#16117) 3 years ago
issue.go Support Issue forms and PR forms (#20987) 2 years ago
issue_content_history.go Make better use of i18n (#20096) 2 years ago
issue_dependency.go Move issues related files into models/issues (#19931) 2 years ago
issue_label.go Move issues related files into models/issues (#19931) 2 years ago
issue_label_test.go Move issues related files into models/issues (#19931) 2 years ago
issue_lock.go Move issues related files into models/issues (#19931) 2 years ago
issue_stopwatch.go Stop spurious APIFormat stopwatches logs (#20008) 2 years ago
issue_test.go Move issues related files into models/issues (#19931) 2 years ago
issue_timetrack.go Move issues related files into models/issues (#19931) 2 years ago
issue_watch.go Move issues related files into models/issues (#19931) 2 years ago
lfs.go Switch Unicode Escaping to a VSCode-like system (#19990) 2 years ago
main_test.go Use a struct as test options (#19393) 2 years ago
middlewares.go Renamed ctx.User to ctx.Doer. (#19161) 2 years ago
migrate.go Unify repo settings & show better error (#19828) 2 years ago
milestone.go Move milestone to models/issues/ (#19278) 2 years ago
packages.go Show hint to link package to repo when viewing empty repo package list (#20504) 2 years ago
patch.go Remove `RequireHighlightJS` field, update plantuml example. (#19615) 2 years ago
projects.go Check if project has the same repository id with issue when assign project to issue (#20133) 2 years ago
projects_test.go Decouple unit test code from business code (#17623) 3 years ago
pull.go Support Issue forms and PR forms (#20987) 2 years ago
pull_review.go Dismiss prior pull reviews if done via web in review dismiss (#20197) 2 years ago
release.go Move some files into models' sub packages (#20262) 2 years ago
release_test.go Move some files into models' sub packages (#20262) 2 years ago
render.go Allow render HTML with css/js external links (#19017) 2 years ago
repo.go fix hard-coded timeout and error panic in API archive download endpoint (#20925) 2 years ago
search.go Remove `RequireHighlightJS` field, update plantuml example. (#19615) 2 years ago
setting.go Move some files into models' sub packages (#20262) 2 years ago
setting_protected_branch.go Move some code into models/git (#19879) 2 years ago
settings_test.go test: use `T.TempDir` to create temporary test directory (#21043) 2 years ago
tag.go Move some code into models/git (#19879) 2 years ago
topic.go Renamed ctx.User to ctx.Doer. (#19161) 2 years ago
treelist.go Feature: Find files in repo (#15028) 2 years ago
view.go Move some files into models' sub packages (#20262) 2 years ago
view_test.go Support localized README (#20508) 2 years ago
webhook.go Fill the specified ref in webhook test payload (#20961) 2 years ago
wiki.go Move some files into models' sub packages (#20262) 2 years ago
wiki_test.go Make git.OpenRepository accept Context (#19260) 2 years ago