You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
d6b96627c1
For a long time Gitea has tested PR patches using a git apply --check method, and in fact prior to the introduction of a read-tree assisted three-way merge in #18004, this was the only way of checking patches. Since #18004, the git apply --check method has been a fallback method, only used when the read-tree three-way merge method has detected a conflict. The read-tree assisted three-way merge method is much faster and less resource intensive method of detecting conflicts. #18004 kept the git apply method around because it was thought possible that this fallback might be able to rectify conflicts that the read-tree three-way merge detected. I am not certain if this could ever be the case. Given the uncertainty here and the now relative stability of the read-tree method - this PR makes using this fallback optional and disables it by default. The hope is that users will not notice any significant difference in conflict detection and we will be able to remove the git apply fallback in future, and/or improve the read-tree three-way merge method to catch any conflicts that git apply method might have been able to fix. An additional benefit is that patch checking should be significantly less resource intensive and much quicker. (See https://github.com/go-gitea/gitea/issues/22083\#issuecomment-1347961737) Ref #22083 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> |
2 years ago | |
|---|---|---|
| .. | ||
| check.go | 2 years ago | |
| check_test.go | 2 years ago | |
| comment.go | 2 years ago | |
| commit_status.go | 2 years ago | |
| edits.go | 2 years ago | |
| lfs.go | 2 years ago | |
| main_test.go | 2 years ago | |
| merge.go | 2 years ago | |
| patch.go | 2 years ago | |
| patch_unmerged.go | 2 years ago | |
| pull.go | 2 years ago | |
| pull_test.go | 2 years ago | |
| review.go | 2 years ago | |
| temp_repo.go | 2 years ago | |
| update.go | 2 years ago | |